Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: enlarge search box on dashboard #8813

Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Mar 15, 2022

Signed-off-by: Takuya Noguchi [email protected]

Description

Enlarges the search box on dashboard.

See the (simplified) sample code:

https://codepen.io/tnir/pen/GRyJoRE

Related Issue(s)

Fixes #8812 (part of #3727)

Improves #3295

How to test

Prepare an environment and resize the window size responsively.

Release Notes

NONE

(or Enlarge search box on dashboard)

Documentation

No.

@tnir
Copy link
Contributor Author

tnir commented Mar 15, 2022

@gtsiolis What do you think?

@@ -72,8 +72,6 @@ export default function () {
}}
/>
</div>
<div className="flex-1" />
<div className="py-3"></div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tackles a technical debt from #5555

@tnir
Copy link
Contributor Author

tnir commented Mar 16, 2022

@svenefftinge Could you review this?

@easyCZ
Copy link
Member

easyCZ commented Mar 16, 2022

@tnir Thank you for your contribution!

@gtsiolis Would you be able to take a look? This looks to fall in your area of expertise.

@gtsiolis
Copy link
Contributor

Looking at this now! 👀

/werft run

@gtsiolis
Copy link
Contributor

/werft run

@tnir
Copy link
Contributor Author

tnir commented Mar 18, 2022

/werft run

👎 not authorized

@gtsiolis
Copy link
Contributor

/werft run

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 18, 2022

Thanks for contributing, @tnir! 🧡

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

In the meatime, please bare with us while we debug why the build is failing for this. 🙏

@tnir
Copy link
Contributor Author

tnir commented Mar 18, 2022

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 18, 2022

I have not been sure why https://www.gitpod.io/cla ...

@tnir That was a private repository where some team members experimented with a CLA automation process so that it's a self-serve process rather than manually reaching out[1] to contributors. Current work-in-progress takes place in #6318.

FWIW, that link to the private repository was added back in https://github.com/gitpod-io/website/pull/1187. I've opened https://github.com/gitpod-io/website/pull/1789 to remove this temporarily until we make the repository public if needed.

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 18, 2022

One more time.

/werft run

👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.3

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 18, 2022

Build succedeed! Triggering one more time because of the timeout.

/werft run

👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.4

@tnir
Copy link
Contributor Author

tnir commented Mar 20, 2022

@meysholdt When can I get reached out from you? 🙏

@tnir
Copy link
Contributor Author

tnir commented Mar 23, 2022

Ping @meysholdt

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 23, 2022

@tnir Sorry this is taking longer than usual but please bare with us as most of the company is currently at our offsite. I promise to get back to this next week. 🎗️

@gtsiolis gtsiolis added the do-not-merge/cla-pending CLA has not been signed label Mar 28, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 28, 2022

/werft run

👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.5

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 28, 2022

/werft run

👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.6

@roboquat roboquat merged commit 8b9a40a into gitpod-io:main Mar 28, 2022
@easyCZ
Copy link
Member

easyCZ commented Mar 28, 2022

Looks like I've accidentally caused the PR to be merged by approving it (did not notice there's no /hold). Sorry, that was not the intent, just intended to indicate the changes look good.

We'll discuss internally if we need to revert. Sorry about this.

@easyCZ
Copy link
Member

easyCZ commented Mar 28, 2022

I've raised a revert for this in #8969. Unfortunately, to get this change in @tnir will need to raise a new PR (such that it's attributed to you). Sorry for the inconvenience.

I'm also looking into how to add hold to PRs by default to prevent this default case scenario.

@jankeromnes
Copy link
Contributor

jankeromnes commented Mar 29, 2022

Thanks again @tnir for your great contribution!

FYI, for convenience, I've restored your commit into a new Pull Request: #8994 -- the commit is still attributed to you, but if you prefer, please feel free to open it in another Pull Request, and I'd be happy to approve it.

Will also ping internally to see what we can do to accelerate the CLA process. 🙂

@tnir tnir deleted the tnir/8812-better-search-box-on-dashboard branch April 10, 2022 23:36
@tnir
Copy link
Contributor Author

tnir commented Apr 14, 2022

Thanks @jankeromnes. Can you help me accelerate the CLA process at #7864 (comment)

Will also ping internally to see what we can do to accelerate the CLA process. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants