-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: enlarge search box on dashboard #8813
ui: enlarge search box on dashboard #8813
Conversation
Signed-off-by: Takuya Noguchi <[email protected]>
@gtsiolis What do you think? |
@@ -72,8 +72,6 @@ export default function () { | |||
}} | |||
/> | |||
</div> | |||
<div className="flex-1" /> | |||
<div className="py-3"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tackles a technical debt from #5555
@svenefftinge Could you review this? |
Looking at this now! 👀 /werft run |
/werft run |
/werft run 👎 not authorized |
/werft run |
Thanks for contributing, @tnir! 🧡 You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓 In the meatime, please bare with us while we debug why the build is failing for this. 🙏 |
Thanks @gtsiolis. I have not been sure why https://www.gitpod.io/cla (originated from https://github.com/gitpod-io/website/blob/45ad1e610c189c3c36585372ccc5a4bf32d37a07/gitpod/docs/contribute/features-and-patches/index.md?plain=1#L16) is dead... 😭 |
@tnir That was a private repository where some team members experimented with a CLA automation process so that it's a self-serve process rather than manually reaching out[1] to contributors. Current work-in-progress takes place in #6318. FWIW, that link to the private repository was added back in https://github.com/gitpod-io/website/pull/1187. I've opened https://github.com/gitpod-io/website/pull/1789 to remove this temporarily until we make the repository public if needed. |
One more time. /werft run 👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.3 |
Build succedeed! Triggering one more time because of the timeout. /werft run 👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.4 |
@meysholdt When can I get reached out from you? 🙏 |
Ping @meysholdt |
@tnir Sorry this is taking longer than usual but please bare with us as most of the company is currently at our offsite. I promise to get back to this next week. 🎗️ |
/werft run 👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.5 |
/werft run 👍 started the job as gitpod-build-tnir-8812-better-search-box-on-dashboard-fork.6 |
Looks like I've accidentally caused the PR to be merged by approving it (did not notice there's no /hold). Sorry, that was not the intent, just intended to indicate the changes look good. We'll discuss internally if we need to revert. Sorry about this. |
Thanks again @tnir for your great contribution! FYI, for convenience, I've restored your commit into a new Pull Request: #8994 -- the commit is still attributed to you, but if you prefer, please feel free to open it in another Pull Request, and I'd be happy to approve it. Will also ping internally to see what we can do to accelerate the CLA process. 🙂 |
Thanks @jankeromnes. Can you help me accelerate the CLA process at #7864 (comment)
|
Signed-off-by: Takuya Noguchi [email protected]
Description
Enlarges the search box on dashboard.
See the (simplified) sample code:
https://codepen.io/tnir/pen/GRyJoRE
Related Issue(s)
Fixes #8812 (part of #3727)
Improves #3295
How to test
Prepare an environment and resize the window size responsively.
Release Notes
(or
Enlarge search box on dashboard
)Documentation
No.