Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial config for CLA Assistant GH Action #6318

Closed
wants to merge 6 commits into from
Closed

Add initial config for CLA Assistant GH Action #6318

wants to merge 6 commits into from

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Oct 20, 2021 •
edited
Loading

Description

This automates our CLA process through the use of cla-assistant/github-action. The signatures are stored in a private repository (gitpod-io/cla).

The message used to prompt the signing of the CLA has been modified so that it makes a distinction between individual users and companies. We are only automating the CLA flow for individuals now as the process for signing on behalf of a company is more complicated and it doesn't happen very often.

TODO

  • Update path-to-document so it points to our CLA
    The CLA is stored in gitpod-io/cla and exposed using GitHub Pages
  • Update the CLA to reflect new process (see PR)
  • Create an access token and add it to secrets using the name CLA_ACTION_ACCESS_TOKEN (see docs)
  • Add any bots that we use to the allowlist (see docs)
  • Either add all Gitpod employees to the allowlist or decide that we'll just have everyone sign the CLA on the next PR
  • Either add all users who have already signed the CLA to the allowlist or decide that we'll just have everyone sign the CLA again
  • Verify that having people "sign" the CLA by leaving a GitHub Pull Request Comment is sufficient legally for us (@meysholdt is verifying this)

Related Issue(s)

Fixes #gitpod-io/ops#130

How to test

Release Notes

NONE

Documentation

@mads-hartmann mads-hartmann added type: improvement Improves an existing feature or existing code do-not-merge/work-in-progress team: devx labels Oct 20, 2021
@mads-hartmann mads-hartmann self-assigned this Oct 20, 2021
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mrsimonemms after the PR has been reviewed.
You can assign the PR to them by writing /assign @mrsimonemms in a comment when ready.

Associated issue: #6

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat requested a review from mrsimonemms October 20, 2021 12:55
@meysholdt meysholdt self-requested a review October 20, 2021 13:06
@mads-hartmann
Use custom message to handle distinction between individuals/company
29d3d20 
We are only automating the CLA flow for individuals now as the process
for signing on behalf of a company is more complicated and it doesn't
happen very often.

gitpod-io/ops#130
@roboquat roboquat added size/M and removed size/S labels Oct 21, 2021
@mads-hartmann mads-hartmann removed the request for review from mrsimonemms October 21, 2021 09:57
@roboquat roboquat added size/L and removed size/M labels Oct 21, 2021
@roboquat roboquat added size/M and removed size/L labels Oct 22, 2021
@JanKoehnlein
Copy link
Contributor

What's the ETA for this?

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 26, 2021 •
edited by werft-gitpod-dev-com bot
Loading

What's the ETA for this?

Came here to ask the same! 🏀

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Oct 26, 2021 •
edited by werft-gitpod-dev-com bot
Loading

@JanKoehnlein @gtsiolis This is only waiting for legal approval, so currently blocked by @meysholdt hearing back from our lawyers ☺️

@gtsiolis gtsiolis mentioned this pull request Oct 31, 2021
Open
8 tasks
@stale
Copy link

stale bot commented Nov 5, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 5, 2021
ghuntley
ghuntley reviewed Nov 8, 2021
View reviewed changes
.github/workflows/cla.yml Outdated Show resolved Hide resolved
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Nov 8, 2021
ghuntley
ghuntley reviewed Nov 8, 2021
View reviewed changes
.github/workflows/cla.yml
# Jordan Hailey (@jordanhailey)
# Ofer Shaal (@shaal),
# Pudong Zheng (@iQQBot)
allowlist: >
Copy link
Contributor

@ghuntley ghuntley Nov 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts: drop all people from this list except robots so we don't need to maintain it cross repos. Use this list only for robots which cannot do the /sign process. Asking everyone to resign isn't a concern + establishes a single source of truth in the signatures.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghuntley I'll remove all the existing signers (it is probably out of date already anyway). For the bots I'll keep them for the first iteration so we can get this out the door and then we can simplify it later.

@mads-hartmann @ghuntley
Update .github/workflows/cla.yml
9920236 
Co-authored-by: Geoffrey Huntley <[email protected]>
@mads-hartmann
Copy link
Contributor Author

@ghuntley Thanks for the fixes and comment!

@gtsiolis gtsiolis mentioned this pull request Nov 17, 2021
Closed
@stale
Copy link

stale bot commented Nov 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 18, 2021
@meysholdt
Copy link
Member

/activity

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Nov 18, 2021
@jankeromnes jankeromnes added the meta: never-stale This issue can never become stale label Nov 22, 2021
@gtsiolis gtsiolis mentioned this pull request Mar 18, 2022
Merged
@tnir
Copy link
Contributor

tnir commented Mar 20, 2022

@mads-hartmann Any updates on this after 6 month from inception?

@gtsiolis gtsiolis mentioned this pull request May 23, 2022
Merged
@tnir
Copy link
Contributor

tnir commented Jun 9, 2022

@mads-hartmann Any updates on this after 9 month from inception?

@tnir
Copy link
Contributor

tnir commented Jun 9, 2022

Or @meysholdt?

@meysholdt
Copy link
Member

I'm planning to pick this up again this week.

@meysholdt meysholdt assigned meysholdt and unassigned mads-hartmann Jun 13, 2022
@meysholdt
Copy link
Member

Closing this PR as we now have a solution based on DocuSign PowerForms.

@meysholdt meysholdt closed this Aug 1, 2022
@Siddhant-K-code Siddhant-K-code deleted the mads/cla-assistant-gh-action branch February 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghuntley ghuntley ghuntley left review comments

@meysholdt meysholdt Awaiting requested review from meysholdt

Assignees

@meysholdt meysholdt

Labels
do-not-merge/work-in-progress meta: never-stale This issue can never become stale release-note-none size/M team: devx type: improvement Improves an existing feature or existing code
Projects
No open projects
☁️ DevX by 🚚 Delivery and Operations Experience Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mads-hartmann @roboquat @JanKoehnlein @gtsiolis @meysholdt @tnir @ghuntley @jankeromnes