[t&p] add workspaces to teams

[svenefftinge]

This PR adds a workspaces tab to teams and projects, showing only the relevant workspaces.
Also under the individual account no workspaces that are created in the context of teams are shown anymore.
This PR also removes active and inactive filter and instead shows both at once. Finally, a few layout things have been aligned based on the design from @gtsiolis.

fixes #4921

How to test

login, create team(s) and create projects below. Now start workspaces for different projects and also non-project contexts.
Verify that the workspaces are shown properly.

NONE

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.1

[svenefftinge]

I'm concerned splitting the workspace lists like this will confuse users. They might look for their workspaces in the wrong place. @gtsiolis @AlexTugarev Can you try and share your thoughts on this?

The main idea was to better communicate which workspaces are accounted to which (account/team). Some thoughts I had are:

• We could have one global workspaces list (maybe workspaces on the top right in the menu).
• Have workspaces tab under user, team, project that by default has a filtered view, but users can remove that filter with one click.

[AlexTugarev]

That's an interesting view. Discoverability of workspaces wasn't nothing I thought of. Now that you picked that up, I think switching context (e.g. searching a workspace in another project) might be more difficult. The easiest way would still be to use a search filter in a single list of workspaces. Perhaps adding a column Project would help in getting a proper view.

[AlexTugarev]

Thinking further, I'd like to raise another concern with "team workspaces". Correct me if I'm wrong, but does this mean, that another team member may restart one of my workspaces? Iff so...

• what about permissions when I want to access the workspace which is started by another user?
• what about data protection? perhaps I left a private key in my workspace by accident, or similar stupid thing
• what about controlling the workspace? may a team member stop my workspace?

[gtsiolis]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.4

[gtsiolis]

Correct me if I'm wrong, but does this mean, that another team member may restart one of my workspaces?

@AlexTugarev The idea was to group workspaces by team and keep ownership and access only to each user as is. ❗

🧀 🧀 🧀 🧀

We could have one global workspaces list

@svenefftinge I think keeping the global list we have now is good for improving (workspace) discoverability and avoid disrupting existing user flows.

🥝 🥝 🥝 🥝

(maybe workspaces on the top right in the menu)

🅰️ One option could be to have a top-level Workspaces menu entry that links back to the existing Workspaces tab within a user. 🅱️ Alternatively, the global list could be a top level page that moves aways from the tabs or a specific namespace (team, etc.)

🅰️ Using Existing Tab	🅱️ Using New Page

🍊 🍊 🍊 🍊

Have workspaces tab under user, team, project that by default has a filtered view, but users can remove that filter with one click.

@svenefftinge We could re-introduce a New Workspace button (primary) on the project page (Branches) which is missing now (❗) and couple it with a View Workspaces button (secondary) that redirects to the global workspaces list filtered down to the 🅰️ project or 🅱️ team. 💭

🅰️ Project	🅱️ Team

🍋 🍋 🍋 🍋

Although out of the scope of these changes, merging active and all workspaces could help.

#5279

[svenefftinge]

@svenefftinge We could re-introduce a New Workspace button (primary) on the project page (Branches) which is missing now (❗) and couple it with a View Workspaces button (secondary) that redirects to the global workspaces list filtered down to the 🅰️ project or 🅱️ team. 💭

🅰️ Project 🅱️ Team

Sounds and looks good to me 👍

🍋 🍋 🍋 🍋

Although out of the scope of these changes, merging active and all workspaces could help.

💯

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.6

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.7

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.8

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.9

[AlexTugarev]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.11

[gtsiolis]

issue: Could we also make the background on the default state for the dark theme darker here like bg-gray-800, besides removing the hover state (see https://github.com/gitpod-io/gitpod/pull/5555/files#r715033220)? Sounds good also as a follow up issue as this affects the Item List component. 😬

BEFORE	AFTER

[svenefftinge]

/werft run

👍 started the job as gitpod-build-se-workspace-for-teams.15

[AlexTugarev]

This isn't a big thing, but for personal and not project-tagged workspaces I'd expect a different message/action than New Project

---

To be fixed in https://github.com/gitpod-io/gitpod/compare/545d11d4904aa6dc4057926fc4830dea22a2b905..714099e0b4f169f8e38fa95890651ff5dd8cc0d3

[AlexTugarev]

/lgtm

Verified that it works as advertised 👍🏻

/hold just in case there are more minor tweaks to do

[roboquat]

LGTM label has been added.

Git tree hash: 51d6f9018f96535cb0567da074f291a8135feb47

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue: #4921

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS [AlexTugarev]
• components/gitpod-db/OWNERS [AlexTugarev]
• components/gitpod-protocol/OWNERS [AlexTugarev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[svenefftinge]

/hold cancel