[server] Temp. disable expensive telemetry queries #8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Don't merge |
|
/werft run 👍 started the job as gitpod-build-gpl-dis-telemetry.3 |
Codecov Report
@@ Coverage Diff @@
## main #8617 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/unhold |
|
/werft run 👍 started the job as gitpod-build-gpl-dis-telemetry.4 |
jankeromnes
reviewed
Mar 7, 2022
| totalUsers: await this.userDb.getUserCount(true), | ||
| totalWorkspaces: await this.workspaceDb.getWorkspaceCount(), | ||
| totalInstances: await this.workspaceDb.getInstanceCount(), | ||
| totalUsers: 0, //await this.userDb.getUserCount(true), |
There was a problem hiding this comment.
Why disable the user count query? (This seems unrelated to an index on workspace.type)
There was a problem hiding this comment.
It was Saturday morning - and retrospectively, I would argue to be consistent 😉
jankeromnes
approved these changes
Mar 7, 2022
AlexTugarev
approved these changes
Mar 7, 2022
|
/unhold |
Pothulapati
added a commit
that referenced
this pull request
Mar 21, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Mar 21, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Mar 21, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Mar 22, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Mar 28, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
roboquat
pushed a commit
that referenced
this pull request
Mar 29, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Mar 30, 2022
#8617 disabled the telemetry fields as those database queries were causing heavy CPU performance. #8858 fixed that issue by adding indexes for those queries. This PR also adds tracing for the telemetry data provider so that we can also count how long they take usually, and how frequently these are called. Signed-off-by: Tarun Pothulapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change disables the execution of all telemetry queries. As discussed with @corneliusludmann this it's meant as a temporary safety measure until a fix (#8638) is merged.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation