Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Temp. disable expensive telemetry queries #8617

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[server] Temp. disable expensive telemetry queries #8617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/server/src/installation-admin/telemetry-data-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
async getTelemetryData(): Promise<TelemetryData> {
const data: TelemetryData = {
installationAdmin: await this.installationAdminDb.getData(),
totalUsers: await this.userDb.getUserCount(true),
totalWorkspaces: await this.workspaceDb.getWorkspaceCount(),
totalInstances: await this.workspaceDb.getInstanceCount(),
totalUsers: 0, //await this.userDb.getUserCount(true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable the user count query? (This seems unrelated to an index on workspace.type)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was Saturday morning - and retrospectively, I would argue to be consistent 😉

totalWorkspaces: 0, //await this.workspaceDb.getWorkspaceCount(),
totalInstances: 0, //await this.workspaceDb.getInstanceCount(),
} as TelemetryData;

return data;
Expand Down