Link to privacy policy from login page #8546
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8546 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
cc: @gtsiolis in case you have any layout feedback - we just added 3 words at the bottom (underline only added in screenshot) - no line breaks.
|
| @@ -209,7 +209,7 @@ export function Login() { | |||
| </div> | |||
| <div className="flex-none mx-auto h-20 text-center"> | |||
| <span className="text-gray-400"> | |||
| By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a>. | |||
| By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a> and <a className="gp-link hover:text-gray-600" target="gitpod-privacy" href="https://www.gitpod.io/privacy/">privacy policy</a>. | |||
There was a problem hiding this comment.
praise: Looks pretty straightforward and also wraps nicely on viewports with smaller width.
| @@ -209,7 +209,7 @@ export function Login() { | |||
| </div> | |||
| <div className="flex-none mx-auto h-20 text-center"> | |||
| <span className="text-gray-400"> | |||
| By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a>. | |||
| By signing in, you agree to our <a className="gp-link hover:text-gray-600" target="gitpod-terms" href="https://www.gitpod.io/terms/">terms of service</a> and <a className="gp-link hover:text-gray-600" target="gitpod-privacy" href="https://www.gitpod.io/privacy/">privacy policy</a>. | |||
There was a problem hiding this comment.
question: We are using a similar notice about terms when installing Gitpod. Does it make sense to also include the privacy policy link there, too?
gitpod/components/dashboard/src/Setup.tsx
Line 48 in f56a9f2
Cc @corneliusludmann because of a relevant discussion.
Cc @mrsimonemms because of #7732 and in case we could drop the privacy link from the telemetry settings in the admin dashboard added in #7732 (review).
Cc @lucasvaltl @gitpod-io/engineering-self-hosted
Description
Change login page to say:
Related Issue(s)
Fixes #8545
How to test
Release Notes