[Dashboard]: add send telemetry to admin settings #7732

mrsimonemms · 2022-01-20T16:04:55Z

Description

This adds the "send telemetry" checkbox to the Admin dashboard and sets the default option to true - the front-end for #7591

It also moves the guardAdminAccess method from the EE gitpod-server-impl.ts to the one in src. This is because we're going to open up more dashboard administrative options to users regardless of whether they have an enterprise license or not - clearly, the option to disable telemetry should be available to all users.

Related Issue(s)

Fixes #7573

How to test

Go to the Dashboard -> Settings and click the "send telemetry" checkbox

Release Notes

[Dashboard]: add send telemetry to admin settings

Documentation

codecov · 2022-01-20T16:08:48Z

Codecov Report

Merging #7732 (9834d65) into main (4f2e71e) will increase coverage by 1.57%.
The diff coverage is n/a.

❗ Current head 9834d65 differs from pull request most recent head 9e9672f. Consider uploading reports for the commit 9e9672f to get more accurate results

@@            Coverage Diff            @@
##            main    #7732      +/-   ##
=========================================
+ Coverage   8.63%   10.20%   +1.57%     
=========================================
  Files         33       18      -15     
  Lines       2339     1009    -1330     
=========================================
- Hits         202      103      -99     
+ Misses      2133      905    -1228     
+ Partials       4        1       -3

Flag	Coverage Δ
components-gitpod-cli-app	`10.20% <ø> (ø)`
components-installation-telemetry-app	`?`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`
installer-raw-app	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
installer/pkg/common/ca.go
installer/pkg/components/ws-manager/role.go
installer/pkg/common/storage.go
installer/pkg/components/ws-manager/rolebinding.go
installer/pkg/components/ws-manager/configmap.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/common/render.go
installer/pkg/common/common.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/common/display.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2e71e...9e9672f. Read the comment docs.

mrsimonemms · 2022-01-21T08:17:05Z

/werft run

👍 started the job as gitpod-build-sje-installation-admin-dashboard.3

mrsimonemms · 2022-01-24T08:29:46Z

/werft run

👍 started the job as gitpod-build-sje-installation-admin-dashboard.7

mrsimonemms · 2022-01-25T12:23:44Z

/assign @gitpod-io/engineering-webapp

components/dashboard/src/admin/Settings.tsx

components/gitpod-db/src/typeorm/installation-admin-db-impl.ts

components/server/src/workspace/gitpod-server-impl.ts

mrsimonemms · 2022-01-26T13:29:49Z

Request changes made

components/server/src/installation-admin/installation-admin-controller.ts

components/gitpod-db/src/installation-admin-db.ts

geropl

Nice @mrsimonemms 🚀

I left two more nits, but feel free to ignore to proceed here!

roboquat · 2022-01-26T14:38:56Z

LGTM label has been added.

Git tree hash: bbd9a19ca4bec142f1ed26d44a299b1131e68f82

mrsimonemms · 2022-01-26T14:41:42Z

@geropl nits fixed

geropl · 2022-01-26T14:51:26Z

/lgtm

roboquat · 2022-01-26T14:51:29Z

LGTM label has been added.

Git tree hash: 6271ab208f8968504a76720a3a148d9360d078f9

roboquat · 2022-01-26T14:51:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, gtsiolis

Associated issue: #7591

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [geropl,gtsiolis]
~~components/gitpod-db/OWNERS~~ [geropl,gtsiolis]
~~components/gitpod-protocol/OWNERS~~ [geropl,gtsiolis]
~~components/server/OWNERS~~ [geropl,gtsiolis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrsimonemms · 2022-01-26T14:52:45Z

@geropl @gtsiolis thank you both for your help/patience on these PRs 🙏🏻 🎉

mrsimonemms · 2022-01-26T14:52:52Z

/unhold

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: webapp Issue belongs to the WebApp team team: delivery Issue belongs to the self-hosted team size/XXL labels Jan 20, 2022

mrsimonemms force-pushed the sje/installation-admin-dashboard branch 2 times, most recently from 7620919 to 38221c8 Compare January 21, 2022 14:20

mrsimonemms force-pushed the sje/installation-admin-dashboard branch 4 times, most recently from 0146564 to 4ffc7dd Compare January 24, 2022 15:12

mrsimonemms changed the title ~~Sje/installation admin dashboard~~ [Dashboard]: add send telemetry to admin settings Jan 24, 2022

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Jan 24, 2022

mrsimonemms force-pushed the sje/installation-admin-dashboard branch 2 times, most recently from ca8094d to fa64af9 Compare January 25, 2022 11:42

roboquat added size/L and removed size/XXL labels Jan 25, 2022

mrsimonemms force-pushed the sje/installation-admin-dashboard branch 2 times, most recently from 009d6a8 to 0951ced Compare January 25, 2022 11:58

mrsimonemms added this to the release/2022.01 milestone Jan 25, 2022

mrsimonemms marked this pull request as ready for review January 25, 2022 12:23

roboquat removed the do-not-merge/work-in-progress label Jan 25, 2022

roboquat assigned geropl Jan 25, 2022

mrsimonemms requested a review from a team January 25, 2022 12:24

geropl reviewed Jan 25, 2022

View reviewed changes

components/dashboard/src/admin/Settings.tsx Outdated Show resolved Hide resolved

geropl reviewed Jan 26, 2022

View reviewed changes

components/gitpod-db/src/typeorm/installation-admin-db-impl.ts Outdated Show resolved Hide resolved

geropl reviewed Jan 26, 2022

View reviewed changes

components/server/src/workspace/gitpod-server-impl.ts Outdated Show resolved Hide resolved

mrsimonemms force-pushed the sje/installation-admin-dashboard branch from 12fbca4 to 24aea53 Compare January 26, 2022 13:28

roboquat removed the lgtm label Jan 26, 2022

mrsimonemms requested a review from geropl January 26, 2022 13:29

geropl reviewed Jan 26, 2022

View reviewed changes

components/server/src/installation-admin/installation-admin-controller.ts Outdated Show resolved Hide resolved

geropl reviewed Jan 26, 2022

View reviewed changes

components/gitpod-db/src/installation-admin-db.ts Outdated Show resolved Hide resolved

geropl approved these changes Jan 26, 2022

View reviewed changes

roboquat added the lgtm label Jan 26, 2022

[dashboard]: create a settings tab inside admin

9e9672f

mrsimonemms force-pushed the sje/installation-admin-dashboard branch from 24aea53 to 9e9672f Compare January 26, 2022 14:41

roboquat removed the lgtm label Jan 26, 2022

roboquat added the lgtm label Jan 26, 2022

roboquat removed the do-not-merge/hold label Jan 26, 2022

roboquat merged commit f9ec0f8 into main Jan 26, 2022

roboquat deleted the sje/installation-admin-dashboard branch January 26, 2022 14:53

This was referenced Jan 27, 2022

Remove the sidebar menu and use the tabs for the admin dashboard #7879

Closed

Remove secondary navigation on the admin dashboard #7668

Closed

[telemetry] Document how telemetry works and what data is sent #7890

Closed

gtsiolis mentioned this pull request Mar 2, 2022

Link to privacy policy from login page #8546

Merged

Pothulapati mentioned this pull request Apr 4, 2022

Epic: Telemetry #7498

Closed

nandajavarma mentioned this pull request May 6, 2022

Hide license type in admin dashboard when not applicable #9767

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard]: add send telemetry to admin settings #7732

[Dashboard]: add send telemetry to admin settings #7732

mrsimonemms commented Jan 20, 2022 •

edited

Loading

codecov bot commented Jan 20, 2022 •

edited

Loading

mrsimonemms commented Jan 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms commented Jan 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms commented Jan 25, 2022

mrsimonemms commented Jan 26, 2022

geropl left a comment

roboquat commented Jan 26, 2022

mrsimonemms commented Jan 26, 2022

geropl commented Jan 26, 2022

roboquat commented Jan 26, 2022

roboquat commented Jan 26, 2022

mrsimonemms commented Jan 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms commented Jan 26, 2022

[Dashboard]: add send telemetry to admin settings #7732

[Dashboard]: add send telemetry to admin settings #7732

Conversation

mrsimonemms commented Jan 20, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

codecov bot commented Jan 20, 2022 • edited Loading

Codecov Report

mrsimonemms commented Jan 21, 2022 • edited by werft-gitpod-dev-com bot Loading

mrsimonemms commented Jan 24, 2022 • edited by werft-gitpod-dev-com bot Loading

mrsimonemms commented Jan 25, 2022

mrsimonemms commented Jan 26, 2022

geropl left a comment

Choose a reason for hiding this comment

roboquat commented Jan 26, 2022

mrsimonemms commented Jan 26, 2022

geropl commented Jan 26, 2022

roboquat commented Jan 26, 2022

roboquat commented Jan 26, 2022

mrsimonemms commented Jan 26, 2022 • edited by werft-gitpod-dev-com bot Loading

mrsimonemms commented Jan 26, 2022

mrsimonemms commented Jan 20, 2022 •

edited

Loading

codecov bot commented Jan 20, 2022 •

edited

Loading

mrsimonemms commented Jan 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms commented Jan 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms commented Jan 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading