Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secondary navigation on the admin dashboard #7668

Closed
gtsiolis opened this issue Jan 18, 2022 · 5 comments
Closed

Remove secondary navigation on the admin dashboard #7668

gtsiolis opened this issue Jan 18, 2022 · 5 comments
Labels
component: dashboard feature: admin dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

When an admin user visits the admin dashboard, the secondary navigation is visible while none of the options is selected since we're currently using a page layout with the left sidebar for selecting Users and Workspaces sub-pages.

Proposal

While we could eventually re-use that secondary navigation as we work towards improving the admin dashboard (#7597), a good MVC (minimum viable change) could be to remove secondary navigation on the admin dashboard.

BEFORE AFTER
Screenshot 2022-01-18 at 11 29 15 PM (2) Screenshot 2022-01-18 at 11 29 31 PM (2)
@gtsiolis gtsiolis added good-first-issue component: dashboard feature: admin dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Jan 18, 2022
@SangameshItagi
Copy link

Hi @gtsiolis
I am interested working on this issue. Can you assign it to me?

@gtsiolis
Copy link
Contributor Author

Hey @SangameshItagi! Yes, feel free to open a pull request (PR) for any open issue without an assignee. 🏓

@gtsiolis
Copy link
Contributor Author

@SangameshItagi While removing the extra tabs is a great MVC (minimum viable change) and you are more than welcome to open a PR about this, just wanted to give a heads-up about what's changed and the long-term direction of the navigation inside the admin dashboard.

Given the recent additions of the settings (#7732) and upcoming addition of projects (#7636) in the admin dashboard, now that we have tabs, which were not preset during the initial dashboard redesign, long-term we'd like to use the tabs and replace the pills we currently have in the admin dashboard as this pattern fits and scales better for this need. I've opened #7879 to track this in case you'd like to pick that issue up instead of this one. Your call. 🏀

@SangameshItagi
Copy link

@gtsiolis Sure will pick #7879 issue, instead of this.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 2, 2022

Closing this in favor of #8385.

@gtsiolis gtsiolis closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: admin dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants