Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cookie Consent banner #8836

Closed
geropl opened this issue Mar 16, 2022 · 19 comments
Closed

Implement Cookie Consent banner #8836

geropl opened this issue Mar 16, 2022 · 19 comments
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team

Comments

@geropl
Copy link
Member

geropl commented Mar 16, 2022

Internal thread: https://gitpod.slack.com/archives/C02EN94AEPL/p1646071841755889

We should align with @mikenikles on a implementation. Suggestions:

@geropl geropl added component: dashboard team: webapp Issue belongs to the WebApp team labels Mar 16, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Mar 16, 2022
@laushinka laushinka self-assigned this Apr 5, 2022
@geropl
Copy link
Member Author

geropl commented Apr 6, 2022

things we need:

  • banner to ask (should be as slick as possible)
  • page to get back, review and change settings

@securitymirco
Copy link
Contributor

  • We need to allow our users to go back to the cookie consent settings, this could be done with a link inside our website footer

@geropl
Copy link
Member Author

geropl commented Apr 6, 2022

  • Cookies to check: Chargebee

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 6, 2022

Re-posting from a relevant discussion (internal):

Is this for the product (dashboard) or the website? For the website we already have a cookie consent banner.

@geropl
Copy link
Member Author

geropl commented Apr 6, 2022

@gtsiolis This is the issue for the webapp parts, but we aim for a single solution for both, website and webapp.
I was not aware that website already has one, do you have a pointer? We just talked with @mikenikles , and he agreed that we need a (new/better?) one.

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 6, 2022

@geropl I could be missing something but:

  1. Here's a screenshot below of the cookie consent banner we already have on the website, implemented in https://github.com/gitpod-io/website/pull/298. Cc @mikenikles
  2. We also recently changed the footnote when logging in the dashboard so that you also accept terms of service and privacy policy, see relevant PR in Link to privacy policy from login page #8546. Cc @jldec
Existing cookine consent banner in www.gitpod.io Terms and privacy policy linked in dashboard login
Screenshot 2022-04-06 at 5 56 36 PM Screenshot 2022-04-06 at 6 02 03 PM

@geropl
Copy link
Member Author

geropl commented Apr 6, 2022

@gtsiolis Thx for the reference! The motivation to touch this is that the current impl/footnote is not GDPR compliant as we learned from @MircoatGitpod . But the current banner looks like sth we could easily use and extend. WDYT @mikenikles ?

@laushinka
Copy link
Contributor

It does look like we can extend the website's cookie banner. Maybe something like this?

Screenshot 2022-04-07 at 09 27 30

@securitymirco
Copy link
Contributor

@laushinka Yes we could implement it like this, great suggestion!

@gtsiolis fyi - I published a description of basic and advanced cookie consent here

@laushinka
Copy link
Contributor

@MircoatGitpod I guess we still need design and wording ideas for the cookie settings?
Also, what does the user see when they click "Reject all"? Currently when they click "Accept Cookies", the banner just disappears slowly.

Looking forward to hearing what @mikenikles thinks too, in case extending the existing banner has limitations.

@securitymirco
Copy link
Contributor

securitymirco commented Apr 7, 2022

@laushinka Good point!

  • "Reject all" should just disregard the banner and only run with strictly necessary cookies.

  • "Modify settings" would bring you into an additional dialog, displaying the categories of cookies we have (Strictly necessary, Functional, Analytics / Performance, Targeting / Marketing) which you can then opt-in to (except strictly necessary). Including descriptions ... I added some wording we can use inside our list of cookies here

@laushinka
Copy link
Contributor

@MircoatGitpod Thanks for the settings wording suggestion!
Should we also still incorporate the terms of service that is in the original wording of the gitpod.io app? It's currently "By signing in, you agree to our terms of service and privacy policy."

@securitymirco
Copy link
Contributor

@laushinka In this case we wouldn't need to add a reference to our terms of service.

@geropl geropl moved this from Scheduled to In Progress in 🍎 WebApp Team Apr 8, 2022
@laushinka
Copy link
Contributor

@jakobhero @MircoatGitpod How do we want this reflected in or sent to our analytics?

@securitymirco
Copy link
Contributor

@jakobhero do you see a good use-case for that?

We definitely need to make sure a user won't get tracked inside our analytics if an opt-out was provided.

@laushinka
Copy link
Contributor

After trying out both creating our own and external solutions, @nisarhassan12 and I decided to develop our own solution. Reasons:

  1. Implementing an external solution only helps us with the initial design, but the functionality will cost the same effort.
  2. This will also reduce the effort in understanding the implementation of an external library and trying to adjust it to our usecase.

Therefore, it would be great to also involve the help of product design @gtsiolis 🙏🏽
cc: @MircoatGitpod

@laushinka
Copy link
Contributor

laushinka commented Apr 12, 2022

Rough idea:

BANNER COOKIE SETTINGS
Screenshot 2022-04-07 at 09 27 30 Screenshot 2022-04-12 at 12 50 54

@laushinka
Copy link
Contributor

After a realignment sync among @MircoatGitpod @geropl @gtsiolis and I, it was decided that since the Dashboard doesn't store any non-necessary cookies, we do not need a cookie banner or settings there.

Next steps:

  1. @MircoatGitpod will create a privacy policy page that will be linked in the Dashboard and website.
  2. The banner and settings will only be implemented in the website. cc @nisarhassan12

Repository owner moved this from In Progress to Done in 🍎 WebApp Team Apr 26, 2022
@laushinka laushinka removed their assignment Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team
Projects
Status: No status
Development

No branches or pull requests

5 participants