Enable cpu limiting using cgroup v2 #8471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8471 +/- ##
===========================================
+ Coverage 12.31% 28.93% +16.61%
===========================================
Files 20 150 +130
Lines 1161 23097 +21936
===========================================
+ Hits 143 6683 +6540
- Misses 1014 15799 +14785
- Partials 4 615 +611
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Furisto
force-pushed
the
fo/v2cpulimit
branch
2 times, most recently
from
1f532ba to
1c78a42
Compare
Furisto
force-pushed
the
fo/v2cpulimit
branch
3 times, most recently
from
9991c07 to
5c28118
Compare
utam0k
reviewed
Mar 4, 2022
| return 0, 0, xerrors.Errorf("cpu.max did not have expected number of fields: %s", parts) | ||
| } | ||
|
|
||
| var quota int64 |
There was a problem hiding this comment.
I think quota is always a positive value, right?
Suggested change
| var quota int64 | |
| var quota uint64 |
|
This PR is quite a great feature for users. I would love to see you write a release note. |
Wasn't sure if we already want to announce it to users 😉 . Added release note. |
This was referenced Mar 7, 2022
|
/werft run 👍 started the job as gitpod-build-fo-v2cpulimit.13 |
|
@utam0k @csweichel PTAL |
utam0k
reviewed
Mar 8, 2022
| return Unknown, err | ||
| } | ||
|
|
||
| func IsUnifiedCgroupSetup() (bool, error) { |
There was a problem hiding this comment.
Thanks for reflecting my opinion❤️
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable cpu limiting using cgroup v2.
Related Issue(s)
#8498
How to test
Notes for reviewers
Considered using containerd cgroups library but
Release Notes