-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cpu limiting using cgroup v2 #8471
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| // Copyright (c) 2022 Gitpod GmbH. All rights reserved. | ||
| // Licensed under the GNU Affero General Public License (AGPL). | ||
| // See License-AGPL.txt in the project root for license information. | ||
|
|
||
| package cgroups | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "strings" | ||
| ) | ||
|
|
||
| const DefaultCGroupMount = "/sys/fs/cgroup" | ||
|
|
||
| type CgroupSetup int | ||
|
|
||
| const ( | ||
| Unknown CgroupSetup = iota | ||
| Legacy | ||
| Unified | ||
| ) | ||
|
|
||
| func (s CgroupSetup) String() string { | ||
| return [...]string{"Legacy", "Unified"}[s] | ||
| } | ||
|
|
||
| func GetCgroupSetup() (CgroupSetup, error) { | ||
| controllers := filepath.Join(DefaultCGroupMount, "cgroup.controllers") | ||
| _, err := os.Stat(controllers) | ||
|
|
||
| if os.IsNotExist(err) { | ||
| return Legacy, nil | ||
| } | ||
|
|
||
| if err == nil { | ||
| return Unified, nil | ||
| } | ||
|
|
||
| return Unknown, err | ||
| } | ||
|
|
||
| func IsUnifiedCgroupSetup() (bool, error) { | ||
| setup, err := GetCgroupSetup() | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| return setup == Unified, nil | ||
| } | ||
|
|
||
| func IsLegacyCgroupSetup() (bool, error) { | ||
| setup, err := GetCgroupSetup() | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| return setup == Legacy, nil | ||
| } | ||
|
|
||
| func EnsureCpuControllerEnabled(basePath, cgroupPath string) error { | ||
| targetPath := filepath.Join(basePath, cgroupPath) | ||
| if enabled, err := isCpuControllerEnabled(targetPath); err != nil || enabled { | ||
| return err | ||
| } | ||
|
|
||
| err := writeCpuController(basePath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| levelPath := basePath | ||
| cgroupPath = strings.TrimPrefix(cgroupPath, "/") | ||
| levels := strings.Split(cgroupPath, string(os.PathSeparator)) | ||
| for _, l := range levels[:len(levels)-1] { | ||
| levelPath = filepath.Join(levelPath, l) | ||
| err = writeCpuController(levelPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func isCpuControllerEnabled(path string) (bool, error) { | ||
| controllerFile := filepath.Join(path, "cgroup.controllers") | ||
| controllers, err := os.ReadFile(controllerFile) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| for _, ctrl := range strings.Fields(string(controllers)) { | ||
| if ctrl == "cpu" { | ||
| // controller is already activated | ||
| return true, nil | ||
| } | ||
| } | ||
|
|
||
| return false, nil | ||
| } | ||
|
|
||
| func writeCpuController(path string) error { | ||
| f, err := os.OpenFile(filepath.Join(path, "cgroup.subtree_control"), os.O_WRONLY, 0) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer f.Close() | ||
|
|
||
| _, err = f.Write([]byte("+cpu")) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // Copyright (c) 2022 Gitpod GmbH. All rights reserved. | ||
| // Licensed under the GNU Affero General Public License (AGPL). | ||
| // See License-AGPL.txt in the project root for license information. | ||
|
|
||
| package cgroups | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "testing" | ||
| ) | ||
|
|
||
| var cgroupPath = []string{"kubepods", "burstable", "pods234sdf", "234as8df34"} | ||
|
|
||
| func createHierarchy(t *testing.T, cpuEnabled bool) (string, string) { | ||
| testRoot := t.TempDir() | ||
| if err := os.WriteFile(filepath.Join(testRoot, "cgroup.controllers"), []byte(""), 0755); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| if err := os.WriteFile(filepath.Join(testRoot, "cgroup.subtree_control"), []byte(""), 0755); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| testCgroup := "" | ||
| for i, level := range cgroupPath { | ||
| testCgroup = filepath.Join(testCgroup, level) | ||
| fullPath := filepath.Join(testRoot, testCgroup) | ||
| if err := os.Mkdir(fullPath, 0o755); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| ctrlFile, err := os.Create(filepath.Join(fullPath, "cgroup.controllers")) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer ctrlFile.Close() | ||
|
|
||
| if cpuEnabled { | ||
| if _, err := ctrlFile.WriteString("cpu"); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
|
|
||
| subTreeFile, err := os.Create(filepath.Join(fullPath, "cgroup.subtree_control")) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer subTreeFile.Close() | ||
|
|
||
| if cpuEnabled && i < len(cgroupPath)-1 { | ||
| if _, err := subTreeFile.WriteString("cpu"); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return testRoot, testCgroup | ||
| } | ||
|
|
||
| func TestEnableController(t *testing.T) { | ||
| root, cgroup := createHierarchy(t, false) | ||
| if err := EnsureCpuControllerEnabled(root, cgroup); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| levelPath := root | ||
| for _, level := range cgroupPath { | ||
| verifyCpuControllerToggled(t, levelPath, true) | ||
| levelPath = filepath.Join(levelPath, level) | ||
| } | ||
|
|
||
| verifyCpuControllerToggled(t, levelPath, false) | ||
| } | ||
|
|
||
| func verifyCpuControllerToggled(t *testing.T, path string, enabled bool) { | ||
| t.Helper() | ||
|
|
||
| content, err := os.ReadFile(filepath.Join(path, "cgroup.subtree_control")) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| if enabled && string(content) != "+cpu" { | ||
| t.Fatalf("%s should have enabled cpu controller", path) | ||
| } else if !enabled && string(content) == "+cpu" { | ||
| t.Fatalf("%s should not have enabled cpu controller", path) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reflecting my opinion❤️