Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache reclaim when cgroup v2. #8629

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Disable cache reclaim when cgroup v2. #8629

merged 2 commits into from
Mar 8, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Mar 7, 2022

Description

Because cache reclaim supports only when using cgroup v1.

Related Issue(s)

Fixes #8497

How to test

  1. Prepare an environment with cgroup v2 enabled e.g. gitpod-k3s-202202181722
  2. Start a workspace
  3. Confirm that ws-daemon doesn't complain error message about the cache reclaim

Release Notes

Disable cache reclaim when cgroup v2

Documentation

No

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #8629 (e4c21bc) into main (bdd31d3) will increase coverage by 3.23%.
The diff coverage is 3.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8629      +/-   ##
==========================================
+ Coverage   11.17%   14.41%   +3.23%     
==========================================
  Files          18       51      +33     
  Lines         993     4899    +3906     
==========================================
+ Hits          111      706     +595     
- Misses        880     4123    +3243     
- Partials        2       70      +68     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-ws-daemon-app 20.33% <4.27%> (?)
components-ws-daemon-lib 20.33% <4.27%> (?)
install-installer-raw-app 4.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/cpulimit/cfs_v2.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/cpulimit/cpulimit.go 68.83% <ø> (ø)
components/ws-daemon/pkg/cpulimit/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/daemon/daemon.go 0.00% <0.00%> (ø)
install/installer/pkg/common/networkpolicies.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/cpulimit/cfs.go 30.52% <55.55%> (ø)
.../installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
install/installer/pkg/common/ca.go 0.00% <0.00%> (ø)
...mponents/ws-daemon/pkg/daemon/cgroup_customizer.go 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409fa71...e4c21bc. Read the comment docs.

@roboquat roboquat added the size/S label Mar 7, 2022
@utam0k
Copy link
Contributor Author

utam0k commented Mar 7, 2022

This PR is a draft because this pr is waiting for solving this discussion.
#8471 (comment)

Because cache reclaim supports only when using cgroup v1.
@utam0k utam0k marked this pull request as ready for review March 8, 2022 05:17
@utam0k utam0k requested a review from a team March 8, 2022 05:17
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 8, 2022
@utam0k
Copy link
Contributor Author

utam0k commented Mar 8, 2022

@Furisto PTAL

@roboquat roboquat merged commit f3a51dc into main Mar 8, 2022
@roboquat roboquat deleted the to/cgv2-mem-2 branch March 8, 2022 10:45
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cache reclaim support v2
3 participants