Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protocol] Make ContextURL.parseToURL support the newly-accepted 'git@{host}:{user}/{repo}.git' format #8100

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[protocol] Make ContextURL.parseToURL support the newly-accepted 'git@{host}:{user}/{repo}.git' format #8100

merged 1 commit into from
Feb 9, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Feb 8, 2022 •
edited
Loading

Companion to #7951 and #8099

Description

Makes ContextURL.parseToURL support the newly-accepted git@{host}:{user}/{repo}.git format

Related Issue(s)

Fixes #8097

How to test

Release Notes

Make `ContextURL.parseToURL` support the newly-accepted `git@{host}:{user}/{repo}.git` format

Documentation

@jankeromnes jankeromnes force-pushed the jx/fix-ssh-context-url branch 3 times, most recently from 16267e0 to fa369b0 Compare February 8, 2022 16:12
@jankeromnes jankeromnes requested a review from geropl February 8, 2022 16:18
@akosyakov
Copy link
Member

We should really switch to use normalizedContextUrl and use companion as fallback for old workspaces.

@jankeromnes jankeromnes force-pushed the jx/fix-ssh-context-url branch from fa369b0 to db93f66 Compare February 8, 2022 16:31
@roboquat roboquat added size/S and removed size/XS labels Feb 8, 2022
@jankeromnes jankeromnes force-pushed the jx/fix-ssh-context-url branch 3 times, most recently from fdeef9a to d80aae7 Compare February 8, 2022 16:54
@geropl
Copy link
Member

geropl commented Feb 8, 2022

@akosyakov We'll have this PR as hotfix, and the other things you mentioned with this PR on Thursday (regular deployment).

@jankeromnes jankeromnes force-pushed the jx/fix-ssh-context-url branch from d80aae7 to b2fbf18 Compare February 8, 2022 17:00
@roboquat roboquat added size/M and removed size/S labels Feb 8, 2022
@jankeromnes
[protocol] Make ContextURL.parseToURL support the newly-accepted 'git…
cd8e9cc 
…@{host}:{user}/{repo}.git' format

Fixes #8097
Companion to #7951
@jankeromnes jankeromnes force-pushed the jx/fix-ssh-context-url branch from b2fbf18 to cd8e9cc Compare February 8, 2022 17:06
@geropl geropl mentioned this pull request Feb 8, 2022
Merged
@codecov
Copy link

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #8100 (cd8e9cc) into main (9792d21) will decrease coverage by 19.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8100       +/-   ##
===========================================
- Coverage   30.79%   10.86%   -19.94%     
===========================================
  Files          39       18       -21     
  Lines        5955     1022     -4933     
===========================================
- Hits         1834      111     -1723     
+ Misses       3982      909     -3073     
+ Partials      139        2      -137
Flag Coverage Δ
components-gitpod-cli-app 10.86% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/terminal/terminal.go
components/supervisor/pkg/config/gitpod-config.go
components/supervisor/pkg/supervisor/user.go
components/supervisor/pkg/ports/tunnel.go
...mponents/supervisor/pkg/supervisor/notification.go
components/supervisor/pkg/terminal/ring-buffer.go
components/local-app/pkg/auth/pkce.go
components/supervisor/pkg/dropwriter/dropwriter.go
components/supervisor/pkg/supervisor/services.go
components/supervisor/pkg/supervisor/tasks.go
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9792d21...cd8e9cc. Read the comment docs.

@jankeromnes jankeromnes mentioned this pull request Feb 8, 2022
Closed
@geropl
Copy link
Member

geropl commented Feb 9, 2022

@jankeromnes Is this "ready for review"? E.g., the commit we deployed yesterday, based on recent main? 🤔

@jankeromnes jankeromnes marked this pull request as ready for review February 9, 2022 09:08
@jankeromnes jankeromnes requested a review from a team February 9, 2022 09:08
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 9, 2022
@jankeromnes
Copy link
Contributor Author

@geropl Sure! The commit works well, and there don't appear to be any conflicts. But if you want, I'm happy to rebase it on top of latest main.

geropl
geropl approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, tested and works! 👍

@roboquat roboquat merged commit 913d963 into main Feb 9, 2022
@roboquat roboquat deleted the jx/fix-ssh-context-url branch February 9, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace list stays blank when displaying git contextURLs
4 participants
@jankeromnes @akosyakov @geropl @roboquat