[server] Support 'git@{host}:{user}/{repo}.git' format in context URLs

[jankeromnes]

Description

Supports context URLs like [email protected]:gitpod-io/gitpod.git by rewriting them to https://github.com/gitpod-io/gitpod.git (without actual SSH authentication)

Related Issue(s)

Fixes #7950

How to test

1. https://jx-ssh-context.staging.gitpod-dev.com/#[email protected]:gitpod-io/gitpod.git

Release Notes

[server] Support 'git@{host}:{user}/{repo}.git' format in context URLs

Documentation

[jankeromnes]

/approve

[JanKoehnlein]

Not sure, doesn't this raise the false expectation that we use ssh to checkout the repo?

[AlexTugarev]

+1 for the change!

WSDYT of trimming to use this magic for GitHub and GitLab only for now?

[JanKoehnlein]

I am overruled LGTM

[roboquat]

LGTM label has been added.

Git tree hash: a4e84bb10a0a63264dc976176caabecf2810a27f

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes, JanKoehnlein

Associated issue: #7950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/server/OWNERS [JanKoehnlein,jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AlexTugarev]

@jankeromnes in addition, we could also rewrite the history/location to make the switch more transparent.

[jankeromnes]

Not sure, doesn't this raise the false expectation that we use ssh to checkout the repo?

@JanKoehnlein Interesting point, thanks for raising it. However, I don't see any implications for cloning via HTTPS instead of SSH. To me, if cloning works, that's fantastic, but if it still fails, we're still in the same situation (i.e. we need to support something new). Did you have any specific worries in mind?

WSDYT of trimming to use this magic for GitHub and GitLab only for now?

@AlexTugarev What are your concerns with Bitbucket and GitLab Self-Managed?

in addition, we could also rewrite the history/location to make the switch more transparent.

I'd love to somehow make the switch more transparent. 💯 However, what do you mean exactly with "rewrite the history/location"?