Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teams] Can create new team with deleted team name #6273

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[teams] Can create new team with deleted team name #6273

merged 1 commit into from
Oct 18, 2021

Conversation

laushinka
Copy link
Contributor

Description

We had users have problems that after deleting a team, they are unable to create a team with the same name.
This PR allows that.

Related Issue(s)

Fixes #6211

How to test

  1. Create a team with any name
  2. Delete the team
  3. Create a team with the same name as the deleted one

Release Notes

Deleted team's name can be reused.

Documentation

@laushinka laushinka requested review from jankeromnes and removed request for JanKoehnlein and AlexTugarev October 18, 2021 14:23
@roboquat roboquat added the team: webapp Issue belongs to the WebApp team label Oct 18, 2021
@laushinka laushinka requested review from gtsiolis and removed request for jankeromnes October 18, 2021 14:23
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Oct 18, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b008501686bcd4934d8cb5e77dd18373c61dce6

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #6211

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f800c5a into main Oct 18, 2021
@roboquat roboquat deleted the laushinka/team-name-6211 branch October 18, 2021 14:36
@gtsiolis
Copy link
Contributor

/woof

@roboquat
Copy link
Contributor

@gtsiolis: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bigint
Copy link

bigint commented Oct 20, 2021 •
edited by werft-gitpod-dev-com bot
Loading

I left my team and now it is an orphan with 0 users 😢, also I cant use the same name again, I think it should be good to allow to leave the last existing user in the team.

@gtsiolis gtsiolis mentioned this pull request Oct 20, 2021
Closed
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 20, 2021 •
edited by werft-gitpod-dev-com bot
Loading

@bigint this could be resolved once we fix #4623. Added #6311 to track database clean up afterwards. 🏀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

Assignees

@JanKoehnlein JanKoehnlein

Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using deleted team name
5 participants
@laushinka @JanKoehnlein @roboquat @gtsiolis @bigint