Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent last owner from leaving the team #4623

Closed
jankeromnes opened this issue Jun 25, 2021 · 7 comments · Fixed by #6477
Closed

Prevent last owner from leaving the team #4623

jankeromnes opened this issue Jun 25, 2021 · 7 comments · Fixed by #6477
Assignees
Labels
component: dashboard deployed Change is completely running in production feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. in discussion Action items being worked out in this issue needs visual design roadmap item: teams & projects team: webapp Issue belongs to the WebApp team

Comments

@jankeromnes
Copy link
Contributor

Currently in Teams & Projects:

  • Owners can remove Members form the team
  • Anyone can leave a team

However, if you're the last Owner of the team and you leave, the team has no owner anymore.

Also, if you're the last person on the team, the team will become empty (and unless someone still has a working invite link, the team name/slug is "burned").

From #4571 (comment):

Some of the possible solutions here:

  1. Keep the Leave option as is and on click trigger a toast notification with an error message explaining that you cannot leave because you are the only remaining owner of the team. Needs: Add toast component in notifications #3530.
  2. Keep the Leave option as a disabled option (red-300) and show a tooltip on hover explaining why you cannot perform this action. See screenshot A below.
  3. Disable the more actions button (gray-400) and show a tooltip on hover. See screenshot B below.
A. Disabled dropdown option B. Disabled dropdown button
Screenshot 2021-06-25 at 4 06 33 PM Screenshot 2021-06-25 at 4 08 04 PM
@jldec
Copy link
Contributor

jldec commented Oct 18, 2021

/schedule

@roboquat
Copy link
Contributor

@jldec: Cannot schedule issue - issue does not belong to a team. Use /team to specify one.

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Oct 18, 2021
@jldec
Copy link
Contributor

jldec commented Oct 18, 2021

/schedule

@laushinka
Copy link
Contributor

Some of the possible solutions here:

  1. Keep the Leave option as is and on click trigger a toast notification with an error message explaining that you cannot leave because you are the only remaining owner of the team. Needs: Add toast component in notifications #3530.
  2. Keep the Leave option as a disabled option (red-300) and show a tooltip on hover explaining why you cannot perform this action. See screenshot A below.
  3. Disable the more actions button (gray-400) and show a tooltip on hover. See screenshot B below.

Or option 4: change the "Leave" option to "Delete team" when they are the last owner of the team. @gtsiolis @jldec

@laushinka laushinka added in discussion Action items being worked out in this issue needs visual design labels Oct 21, 2021
@jldec
Copy link
Contributor

jldec commented Oct 21, 2021

I would prefer some visible notification like a toast (not just a tooltip) OR

  1. change red Leave Team to a non-clickable, gray Leave Team with a message right below it saying "The last remaining owner of a team cannot leave the team."

@svenefftinge
Copy link
Member

svenefftinge commented Oct 25, 2021

@jldec I think you should create a fresh issue with a clear actionable description of your preferred solution. This ticket (especially the title) still sounds very unclear.

@jldec jldec changed the title Figure out what should happen when the last team owner tries to leave the team Prevent last owner from leaving the team Oct 25, 2021
@jldec
Copy link
Contributor

jldec commented Oct 25, 2021

Updated with clearer title.

  • The main priority for this is to prevent the last owner from leaving the team.
  • My preferred design for how best to do this would be to disable the action inside the dropdown and provide a visible explanation inside the dropdown as well (not tooltip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard deployed Change is completely running in production feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. in discussion Action items being worked out in this issue needs visual design roadmap item: teams & projects team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Status: Low hanging fruits 🍒
8 participants