Allow using deleted team name

[jankeromnes]

Currently, in the context of the new Teams & Projects UI, there are two problems related to the deletion of a Team:

• When you delete a Team, it is not possible to create a new Team that has the same slug as the deleted Team (e.g. a Team with the same name)

To fix this, the TeamsDB should ignore all teams that have markedDeleted: true when looking at existing teams / existing team slugs / etc (the same way as it currently ignores all teams that have deleted: true):

gitpod/components/gitpod-db/src/typeorm/team-db-impl.ts

Lines 126 to 129 in 6bf6485

	const existingTeam = await teamRepo.findOne({ slug, deleted: false });
	if (!!existingTeam) {
	throw new Error('A team with this name already exists');
	}

Note: This also applies to all locations in TeamsDB where deleted: false is required.

---

- [ ] When you are the last person to leave a Team, the team ends up having 0 members (hence no longer being accessible to anyone) Issue exists in #4623

In this case (when the last person leaves), the Team should also get markedDeleted:

gitpod/components/gitpod-db/src/typeorm/team-db-impl.ts

Lines 203 to 204 in 6bf6485

	membership.deleted = true;
	await membershipRepo.save(membership);

[gtsiolis]

Thanks for opening this @jankeromnes!

For the first point, see #5066 (comment). Cc @laushinka @svenefftinge

For the second point, see #4623.

[JanKoehnlein]

/schedule

[roboquat]

@JanKoehnlein: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[laushinka]

@jankeromnes Thanks for this issue! Yes, the first point makes sense. Re the second point, it seems that there are more solution options as @gtsiolis linked. Should it be tackled in that issue instead (and have it updated in case of staleness)?

[laushinka]

/assign

[jldec]

@laushinka I have scheduled #4623 since there was already some work done there on the last-member deletion UX.

cc: @gtsiolis