Add teams deprecation notice #5121
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #5118 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gtsiolis
force-pushed
the
gt/add-teams-deprecation-notice
branch
from
3079318 to
e0eb1b3
Compare
There was a problem hiding this comment.
Reused the same component as in the editor deprecation and garbage collection warning with some small changes to try out a new visual design. What do you think? Feel free to make any suggestions directly on the changes. 🏀
| Editor Deprecation | Garbage Collection |
|---|---|
 |
 |
| @@ -527,6 +528,16 @@ function AllTeams() { | |||
| <div className="flex-grow "> | |||
| <h3 className="self-center">All Teams</h3> | |||
| <h2>Manage teams and team members.</h2> | |||
| <ItemsList className="pt-2"> | |||
| <Item className="w-full bg-yellow-200 hover:bg-yellow-200 py-6 px-6"> | |||
There was a problem hiding this comment.
This is also using some new colors for this alert component variant, compared to the component used for Theia deprecation or garbage collection. 🖍️
| @@ -527,6 +528,16 @@ function AllTeams() { | |||
| <div className="flex-grow "> | |||
| <h3 className="self-center">All Teams</h3> | |||
| <h2>Manage teams and team members.</h2> | |||
| <ItemsList className="pt-2"> | |||
| <Item className="w-full bg-yellow-200 hover:bg-yellow-200 py-6 px-6"> | |||
There was a problem hiding this comment.
issue(non-blocking): Added hover:bg-yellow-200 here only to bypass the redundant hover state in this case, most probably introduced in #4454.
| <ItemField className=" flex flex-col"> | ||
| <div className="text-yellow-600 font-semibold">DEPRECATION NOTICE</div> | ||
| <p className="text-yellow-800"> | ||
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>. |
There was a problem hiding this comment.
issue(blocking): The first link here should link to some documentation which does not exist yet. Alternatively, We could drop the last sentence here for now and add it back once we have some documentation we can link to.
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>. | |
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. |
| @@ -527,6 +528,16 @@ function AllTeams() { | |||
| <div className="flex-grow "> | |||
| <h3 className="self-center">All Teams</h3> | |||
| <h2>Manage teams and team members.</h2> | |||
| <ItemsList className="pt-2"> | |||
There was a problem hiding this comment.
question: Not sure if this needs to be added also below L431 to make it visible at all times. Cc @AlexTugarev
| <ItemField className=" flex flex-col"> | ||
| <div className="text-yellow-600 font-semibold">DEPRECATION NOTICE</div> | ||
| <p className="text-yellow-800"> | ||
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>. |
There was a problem hiding this comment.
suggestion: Minor rephrasing to match changes in https://github.com/gitpod-io/gitpod/pull/5126/files#diff-45333399769993ee06ff1de23fb9aaea15cc06ec5a941eb8fef46421082a589eR18:
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>. | |
| Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>. |
|
/werft run 👍 started the job as gitpod-build-gt-add-teams-deprecation-notice.3 |
gtsiolis
added
feature: teams and projects [DEPRECATED]
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keeping this closed, see #5118 (comment) |
This will add a deprecation notice for existing teams.
Fix #5118.
/teams