Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teams deprecation notice #5121

Closed
wants to merge 1 commit into from
Closed

Add teams deprecation notice #5121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions components/dashboard/src/settings/Teams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error";
import { poll, PollOptions } from "../utils";
import settingsMenu from "./settings-menu";
import { Disposable } from "@gitpod/gitpod-protocol";
import { Item, ItemField, ItemsList } from "../components/ItemsList";

export default function Teams() {

Expand Down Expand Up @@ -527,6 +528,16 @@ function AllTeams() {
<div className="flex-grow ">
<h3 className="self-center">All Teams</h3>
<h2>Manage teams and team members.</h2>
<ItemsList className="pt-2">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Not sure if this needs to be added also below L431 to make it visible at all times. Cc @AlexTugarev

<Item className="w-full bg-yellow-200 hover:bg-yellow-200 py-6 px-6">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also using some new colors for this alert component variant, compared to the component used for Theia deprecation or garbage collection. 🖍️

Copy link
Contributor Author

@gtsiolis gtsiolis Aug 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(non-blocking): Added hover:bg-yellow-200 here only to bypass the redundant hover state in this case, most probably introduced in #4454.

<ItemField className=" flex flex-col">
<div className="text-yellow-600 font-semibold">DEPRECATION NOTICE</div>
<p className="text-yellow-800">
Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): The first link here should link to some documentation which does not exist yet. Alternatively, We could drop the last sentence here for now and add it back once we have some documentation we can link to.

Suggested change
Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>.
Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Minor rephrasing to match changes in https://github.com/gitpod-io/gitpod/pull/5126/files#diff-45333399769993ee06ff1de23fb9aaea15cc06ec5a941eb8fef46421082a589eR18:

Suggested change
Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. There's no action required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>.
Hey! We're introducing <strong>Teams & Projects</strong> to surface <strong>Prebuilds</strong> in the dashboard. All existing teams will be migrated over the upcoming weeks. No action is required on your side. <a href="/new" className="learn-more">Learn more about Teams & Projects</a> or <a href="/new" className="learn-more">Create a New Team</a>.

</p>
</ItemField>
</Item>
</ItemsList>
</div>
</div>
)}
Expand Down