Rename teams to team plans #6011
Conversation
gtsiolis
added
component: dashboard
team: webapp
gtsiolis
requested review from
jankeromnes
and removed request for
geropl and
jankeromnes
| @@ -18,7 +18,7 @@ export default [ | |||
| link: ['/plans'] | |||
| }, | |||
| { | |||
| title: 'Teams', | |||
| title: 'Team Plans', | |||
There was a problem hiding this comment.
thought: Alternatively, this could read Subscriptions.
There was a problem hiding this comment.
So, the reason we initially went with "Plans" and not "Subscriptions" for the individual "Plans" page is:
- An individual has only one Subscription with Gitpod (paid or not), but that Subscription can be upgraded/downgraded to various Plans (e.g. Open Source, Professional, Unleashed, etc)
So the page could have been called "Subscription" (singular) or "Plans" (plural). We felt "Plans" more appropriate, because that's exactly what this page shows you (a collection of available Plans for your unique Subscription).
For Teams, this is a bit more awkward, because you can possibly have up to three Team Subscriptions (one for each Team Plan).
I'm a bit more in favour of "Team Plans" (to be consistent with "Plans"), but I agree that this could also become "Team Subscriptions".
There was a problem hiding this comment.
Looks good to me! Many thanks @gtsiolis 🙏
Please see small inline nits, otherwise good to merge 🚀
| @@ -428,7 +428,7 @@ function AllTeams() { | |||
| <div className="flex flex-row"> | |||
| <div className="flex-grow "> | |||
| <h3 className="self-center">All Teams</h3> | |||
| <h2>Manage teams and team members.</h2> | |||
| <h2>Manage team plan and team members.</h2> | |||
There was a problem hiding this comment.
| <h2>Manage team plan and team members.</h2> | |
| <h2>Manage team plans and team members.</h2> |
| @@ -428,7 +428,7 @@ function AllTeams() { | |||
| <div className="flex flex-row"> | |||
| <div className="flex-grow "> | |||
| <h3 className="self-center">All Teams</h3> | |||
There was a problem hiding this comment.
| <h3 className="self-center">All Teams</h3> | |
| <h3 className="self-center">All Team Plans</h3> |
|
LGTM label has been added. Git tree hash: 1f7c929b50f4ad6a5b741e5f79e6312d96c4e202
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes Associated issue: #698 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Whoops, forgot about auto-merge... 😅 Anyway, please feel free to address the nits in a follow-up PR. Thanks again! |
|
Oh, this got merged early! 🙀 Added follow-up PR in #6013. Thanks for taking a look at this, @jankeromnes! |
Description
This will rename the current Teams feature to Team Plans to avoid confusion with the upcoming Teams & Projects feature which will introduce a way to create a team and invite members. 🍵
We've decided to proceed with this MVC (minimum viable change) instead of adding a deprecation notice in #5121. 🙀
There's also a follow up PR to update the relevant docs section in https://github.com/gitpod-io/website/pull/1032.
See relevant discussion points[1][2] (internal).
How to test
/teamsRelease Notes