Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvc] fix when opening repo with no .gitpod.yml #13552

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[pvc] fix when opening repo with no .gitpod.yml #13552

merged 1 commit into from
Oct 6, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Oct 3, 2022 •
edited by jenting
Loading

Description

Related Issue(s)

Fixes #13531

How to test

Open preview env
Enable PVC flag
Open workspace that has no .gitpod.yml file in repo, eg: https://github.com/utam0k/utam0k.github.io

Release Notes

none

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13531.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/M and removed size/S labels Oct 4, 2022
@sagor999 sagor999 force-pushed the pavel/13531 branch 3 times, most recently from 766dcca to b870541 Compare October 4, 2022 01:19
@sagor999
Copy link
Contributor Author

sagor999 commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-pavel-13531.7
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13531.8
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-pavel-13531.9
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13531.12
(with .werft/ from main)

@sagor999 sagor999 marked this pull request as ready for review October 4, 2022 19:00
@sagor999 sagor999 requested a review from a team October 4, 2022 19:00
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 4, 2022
jenting
jenting reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration test for this? To prevent the regression, thank you.

Never mind, I saw there is an related issue created.

@kylos101
Copy link
Contributor

kylos101 commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft with-integration-tests=workspace

👎 unknown command: with-integration-tests=workspace
Use /werft help to list the available commands

@kylos101
Copy link
Contributor

kylos101 commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-pavel-13531.13
(with .werft/ from main)

@kylos101
Copy link
Contributor

kylos101 commented Oct 5, 2022 •
edited
Loading

👋 hey @sagor999 , the tests are ran here, I see some failures and do not recommend we approve and merge until they are handled (there are also test failures in main, 😭 , but they do not match these test cases 👇 ).

[test-ws-manager] --- FAIL: TestMissingBackup (143.78s)
[test-ws-manager]     --- FAIL: TestMissingBackup/CreateWorkspace (143.78s)
[test-ws-manager]         --- FAIL: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one (143.78s)
[test-ws-manager]             --- PASS: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/classic_backup_init (10.83s)
[test-ws-manager]             --- PASS: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/fwb_backup_init (10.70s)
[test-ws-manager]             --- FAIL: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/pvc_backup_init (35.53s)

I think we may have to delay this change, and extend Gitpodders using PVC (with a caveat that the repo must have a .gitpod.yml), and rely on gen71 for this fix before opening PVC up to a larger audience. 😿 The plus side is, at least we'll still have the possible fix for mount volume errors. 😸

cc: @jenting as PVC partner in crime and @aledbf as gen70 deployer.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13531.15 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13531.16
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-13531.17
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022

This test failed.

content_test.go:410: restarted workspace did not fail despite missing backup, &{id:"6c3e0663-e97f-41a8-b685-06e927bb9c1f"  service_prefix:"99225cfe-c5fe-46c9-b0bf-313d343986d8"  metadata:{owner:"builtin-user-workspace-probe-0000000"  meta_id:"bronze-cod-gqk462ce"}  spec:{workspace_image:"eu.gcr.io/gitpod-core-dev/build/workspace-images:83a9d3182651700079941607ed08dd881ae242394d76ed2221520cbda3b79230"  deprecated_ide_image:"eu.gcr.io/gitpod-core-dev/build/ide/code:commit-97cff52e43760ad3ad96aa82d9fba934c5f53be8"  feature_flags:PERSISTENT_VOLUME_CLAIM  initializer:{backup:{}}  workspace_location:"/"  git:{username:"integration-test"  email:"[email protected]"}  timeout:"30m"  ide_image:{web_ref:"eu.gcr.io/gitpod-core-dev/build/ide/code:commit-97cff52e43760ad3ad96aa82d9fba934c5f53be8"}} https://99225cfe-c5fe-46c9-b0bf-313d343986d8.ws.pavel-13531.preview.gitpod-dev.com id:"6c3e0663-e97f-41a8-b685-06e927bb9c1f"  status_version:109114836582401  metadata:{owner:"builtin-user-workspace-probe-0000000"  meta_id:"bronze-cod-gqk462ce"  started_at:{seconds:1664960268}}  spec:{workspace_image:"eu.gcr.io/gitpod-core-dev/build/workspace-images:83a9d3182651700079941607ed08dd881ae242394d76ed2221520cbda3b79230"  deprecated_ide_image:"eu.gcr.io/gitpod-core-dev/build/ide/code:commit-97cff52e43760ad3ad96aa82d9fba934c5f53be8"  url:"https://99225cfe-c5fe-46c9-b0bf-313d343986d8.ws.pavel-13531.preview.gitpod-dev.com"  timeout:"30m"  ide_image:{web_ref:"eu.gcr.io/gitpod-core-dev/build/ide/code:commit-97cff52e43760ad3ad96aa82d9fba934c5f53be8"}  class:"default"}  phase:RUNNING  conditions:{volume_snapshot:{}}  runtime:{node_name:"pavel-13531"  pod_name:"ws-6c3e0663-e97f-41a8-b685-06e927bb9c1f"  node_ip:"10.0.2.2"}  auth:{owner_token:"VORPBHxAmKYVisgni8WFSelSvDG2EtR0"}}
--- FAIL: TestMissingBackup (36.00s)
    --- FAIL: TestMissingBackup/CreateWorkspace (36.00s)
        --- FAIL: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one (36.00s)
            --- PASS: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/classic_backup_init (0.88s)
            --- PASS: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/fwb_backup_init (0.86s)
            --- FAIL: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one/pvc_backup_init (10.86s)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022

ah, I know why. I will fix it shortly.

@sagor999 sagor999 mentioned this pull request Oct 5, 2022
Merged
3 tasks
@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-13531.20
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-13531.21
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13531.22
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022

@jenting PTAL, tests are passing now. 🙏

@sagor999 sagor999 requested a review from jenting October 5, 2022 22:35
@roboquat roboquat merged commit 27068da into main Oct 6, 2022
@roboquat roboquat deleted the pavel/13531 branch October 6, 2022 00:33
@kylos101
Copy link
Contributor

kylos101 commented Oct 6, 2022 •
edited
Loading

@sagor999 @jenting hey guys, it looks like the tests failed:

[components/ws-manager:app] --- FAIL: TestModifyFinalizer (65.29s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/add_finalizer (6.20s)
[components/ws-manager:app]     --- FAIL: TestModifyFinalizer/add_finalizer_noop (21.21s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/remove_finalizer (23.86s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/remove_finalizer_noop (14.02s)

Is there a more recent run where they passed? I am looking at this: https://werft.gitpod-dev.com/job/gitpod-build-jenting-13531.3/raw and https://werft.gitpod-dev.com/job/gitpod-build-jenting-13531.2 (the second one is what Github links to as a failed check).

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 6, 2022

This is the build from this PR that is green: https://werft.gitpod-dev.com/job/gitpod-build-pavel-13531.22

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022

https://werft.gitpod-dev.com/job/gitpod-build-main.5041/

@sagor999 @jenting hey guys, it looks like the tests failed:

[components/ws-manager:app] --- FAIL: TestModifyFinalizer (65.29s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/add_finalizer (6.20s)
[components/ws-manager:app]     --- FAIL: TestModifyFinalizer/add_finalizer_noop (21.21s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/remove_finalizer (23.86s)
[components/ws-manager:app]     --- PASS: TestModifyFinalizer/remove_finalizer_noop (14.02s)

Is there a more recent run where they passed? I am looking at this: https://werft.gitpod-dev.com/job/gitpod-build-jenting-13531.3/raw and https://werft.gitpod-dev.com/job/gitpod-build-jenting-13531.2 (the second one is what Github links to as a failed check).

The link is incorrect. The link point to my branch jenting/13531.

The is the correct werft link https://werft.gitpod-dev.com/job/gitpod-build-main.5041
But the rest logs be truncated so we can't know the failure reason.

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PVC] unable to open the workspace with download initializer
4 participants
@sagor999 @kylos101 @jenting @roboquat