Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvc] add a test for non gitpodified repo #13593

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[pvc] add a test for non gitpodified repo #13593

merged 1 commit into from
Oct 6, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Oct 4, 2022 •
edited
Loading

Description

Add integration test that tests PVC against non gitpodified repo.

Related Issue(s)

Fixes #13591

How to test

Release Notes

none

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13591.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13591.2 because the annotations in the pull request description changed
(with .werft/ from main)

jenting
jenting approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@jenting
Copy link
Contributor

jenting commented Oct 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13591.3
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 5, 2022

This depends on this #13552 merged first, so holding it in non ready for review until then.

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13591.5
(with .werft/ from main)

@sagor999
Copy link
Contributor Author

sagor999 commented Oct 6, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pavel-13591.6
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pavel-13591.7
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022

CI pass

@jenting
Copy link
Contributor

jenting commented Oct 6, 2022

This depends on this #13552 merged first, so holding it in non ready for review until then.

The PR merged

/unhold

@jenting jenting marked this pull request as ready for review October 6, 2022 05:44
@roboquat roboquat merged commit 58b1561 into main Oct 6, 2022
@roboquat roboquat deleted the pavel/13591 branch October 6, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PVC] integration test for testing .gitpod.yml using incorrect repo
3 participants
@sagor999 @jenting @roboquat