[PVC] unable to open the workspace with download initializer

[jenting]

Bug description

function GetContentLayerPVC returns no backup or valid initializer present when the StartWorkspace request with the download initializer.

gitpod/components/ws-manager/pkg/manager/imagespec.go

Lines 50 to 107 in 14a1ffd

	if fullWorkspaceBackupEnabled || pvcFeatureEnabled {
	owner := pod.Labels[wsk8s.OwnerLabel]
	workspaceID := pod.Labels[wsk8s.MetaIDLabel]
	initializerRaw, ok := pod.Annotations[workspaceInitializerAnnotation]
	if !ok {
	return nil, xerrors.Errorf("pod %s has no %s annotation", pod.Name, workspaceInitializerAnnotation)
	}
	initializerPB, err := base64.StdEncoding.DecodeString(initializerRaw)
	if err != nil {
	return nil, xerrors.Errorf("cannot decode init config: %w", err)
	}
	var initializer csapi.WorkspaceInitializer
	err = proto.Unmarshal(initializerPB, &initializer)
	if err != nil {
	return nil, xerrors.Errorf("cannot unmarshal init config: %w", err)
	}
	var cl []layer.Layer
	if pvcFeatureEnabled {
	cl, _, err = m.Content.GetContentLayerPVC(ctx, owner, workspaceID, &initializer)
	} else {
	cl, _, err = m.Content.GetContentLayer(ctx, owner, workspaceID, &initializer)
	}
	if err != nil {
	return nil, xerrors.Errorf("cannot get content layer: %w", err)
	}
	contentLayer := make([]*regapi.ContentLayer, len(cl))
	for i, l := range cl {
	if len(l.Content) > 0 {
	contentLayer[i] = &regapi.ContentLayer{
	Spec: &regapi.ContentLayer_Direct{
	Direct: &regapi.DirectContentLayer{
	Content: l.Content,
	},
	},
	}
	continue
	}
	diffID := l.DiffID
	contentLayer[i] = &regapi.ContentLayer{
	Spec: &regapi.ContentLayer_Remote{
	Remote: &regapi.RemoteContentLayer{
	DiffId: diffID,
	Digest: l.Digest,
	MediaType: string(l.MediaType),
	Url: l.URL,
	Size: l.Size,
	},
	},
	}
	}
	spec.ContentLayer = contentLayer
	}
	return &regapi.GetImageSpecResponse{
	Spec: spec,
	}, nil

Steps to reproduce

Set the persistent_volume_claim feature for your user

Open the workspace from the repo https://github.com/utam0k/utam0k.github.io

https://gitpod.slack.com/archives/C02F19UUW6S/p1664770050148509

Workspace affected

No response

Expected behavior

It should open the workspace.

Example repository

https://github.com/utam0k/utam0k.github.io

Anything else?

#7901

[jenting]

cc @sagor999

[jenting]

Since the code of PVC is similar to FWB.
So I enabled the FWB and opened the https://github.com/utam0k/utam0k.github.io, and it failed with the same error message.

[sagor999]

@jenting do not use FWB. that code has not been tested in a very long time.

[jenting]

@jenting do not use FWB. that code has not been tested in a very long time.

I want to ensure the FWB would hit the same error because the code is similar.