Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Ensure PVC workspace class does not change on restart #12734

Merged
merged 1 commit into from
Sep 8, 2022
Merged

[server] Ensure PVC workspace class does not change on restart #12734

merged 1 commit into from
Sep 8, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Sep 7, 2022 •
edited by kylos101
Loading

Description

  • Ensure PVC workspace class does not change on restart
  • Use pvc class if prebuild is pvc if user would get legacy pvc class

Related Issue(s)

Fixes #12666
Fixes #12494

How to test

  • Select large workspace class in your user preferences
  • Enable persistent_volume_claim feature for your user in the preview environment via administration
  • Start prebuild -> prebuild should have g1-large-pvc
  • Create regular workspace from prebuild (should have g1-large-pvc)
  • Stop workspace
  • Restart workspace (should have g1-large-pvc)

Release Notes

None

Werft options:

  • /werft with-preview

@Furisto Furisto added the team: workspace Issue belongs to the Workspace team label Sep 7, 2022
@Furisto Furisto marked this pull request as ready for review September 7, 2022 12:44
@Furisto Furisto requested a review from a team September 7, 2022 12:44
@Furisto Furisto requested a review from jenting September 7, 2022 12:44
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 7, 2022
@Furisto Furisto linked an issue Sep 7, 2022 that may be closed by this pull request
[PVC] Open a fresh new workspace, it uses large node pool. Relaunch the workspace, it uses standard node pool #12666
Closed
@jenting
Copy link
Contributor

jenting commented Sep 7, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.5
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 7, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.6
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.7
(with .werft/ from main)

@kylos101 kylos101 requested a review from sagor999 September 8, 2022 00:50
sagor999
sagor999 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

/hold
hold for others to review

@jenting
Copy link
Contributor

jenting commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.8
(with .werft/ from main)

@jenting jenting force-pushed the furisto/pvc-open-a-fresh-new-workspace-12666 branch from 7458a10 to 9842b58 Compare September 8, 2022 05:09
@jenting
Copy link
Contributor

jenting commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.10
(with .werft/ from main)

@jenting
Copy link
Contributor

jenting commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-furisto-pvc-open-a-fresh-new-workspace-12666.11
(with .werft/ from main)

jenting
jenting approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work like a charm, thank you.

@jenting
Copy link
Contributor

jenting commented Sep 8, 2022

/unhold

@jenting jenting mentioned this pull request Sep 8, 2022
Closed
easyCZ
easyCZ approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't feel particularly elegant but I lack context to suggest an alternative.

Looks safe enough.

components/server/src/workspace/workspace-starter.ts
);
if (prebuildClass?.endsWith("-pvc")) {
workspaceClass = prebuildClass;
// ####
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ####

@roboquat roboquat merged commit 1b64527 into main Sep 8, 2022
@roboquat roboquat deleted the furisto/pvc-open-a-fresh-new-workspace-12666 branch September 8, 2022 20:49
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Sep 9, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Sep 20, 2022
@roboquat roboquat added the deployed Change is completely running in production label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

@sagor999 sagor999 sagor999 approved these changes

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
5 participants
@Furisto @jenting @easyCZ @sagor999 @roboquat