Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVC] Open a fresh new workspace, it uses large node pool. Relaunch the workspace, it uses standard node pool #12666

Closed
Tracked by #7901
jenting opened this issue Sep 6, 2022 · 2 comments · Fixed by #12734
Assignees
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@jenting
Copy link
Contributor

jenting commented Sep 6, 2022

Bug description

The user workspace class preference is standard.
The prebuild was built with large workspace class.

Open a fresh new workspace from the prebuild project, and then the workspace uses the large node pool because the prebuild was built on a large node pool. Relaunch the workspace, and then it uses a standard node pool. So, the workspace pod can't be up.

This is because the VolumeSnapshot size is 50Gi, and the PVC size is 30Gi.

Steps to reproduce

Prepare the prebuild project

  • Set the user's workspace class preference as large
  • Configure a prebuild project and run the prebuild

Open workspace from the prebuild project

  • Set the user's workspace class preference as standard
  • Enable the user's PVC feature flag
  • Do not enable the project to prebuild PVC feature flag
  • Open the new workspace from the prebuild project
    image
  • Make sure the workspace is using the large node pool g1-large-pvc by checking the label kubectl get pod <pod-name> --show-labels | grep gitpod.io/workspaceClass
  • Check the corresponding PVC with size 50Gi
  • Stop the workspace
  • Check the VolumeSnapshot size is 50Gi
  • Reopen the workspace. The workspace can't be open
    • The workspace pod is using the standard node pool g1-standard-pvc by checking the label kubectl get pod <pod-name> --show-labels | grep gitpod.io/workspaceClass
    • The workspace pvc size is 30Gi
    • The workspace pvc restored from the VolumeSnapshot, the VolumeSnapshot size is 50Gi
      image

Workspace affected

No response

Expected behavior

The workspace should keep use the large node pool. So the workspace can be open.

Example repository

No response

Anything else?

#7901

Similar to #12494

@jenting jenting added the type: bug Something isn't working label Sep 6, 2022
@jenting jenting added the team: workspace Issue belongs to the Workspace team label Sep 6, 2022
@jenting jenting moved this to In Progress in 🌌 Workspace Team Sep 6, 2022
@jenting jenting self-assigned this Sep 6, 2022
@kylos101 kylos101 assigned Furisto and unassigned jenting Sep 6, 2022
@kylos101
Copy link
Contributor

kylos101 commented Sep 6, 2022

Reassigning to @Furisto given this thread

@jenting
Copy link
Contributor Author

jenting commented Sep 7, 2022

Note: it happens only with the PVC feature flag.

@Furisto Furisto linked a pull request Sep 7, 2022 that will close this issue
1 task
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Sep 8, 2022
@jenting jenting moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Sep 9, 2022
@Furisto Furisto moved this from In Validation to Done in 🌌 Workspace Team Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants