Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVC] Can't open from prebuilds if prebuilds with large workspace class but user prefers standard workspace class #12494

Closed
Tracked by #7901
jenting opened this issue Aug 30, 2022 · 6 comments · Fixed by #12734
Assignees
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@jenting
Copy link
Contributor

jenting commented Aug 30, 2022

Bug description

Prebuilds was built with a large workspace class (50Gi), and the user prefers a standard workspace class (30Gi).
The user cannot open the workspace because the PVC disk size is 30Gi, not 50Gi.

Steps to reproduce

  • Force the prebuilds to build with a large workspace class (50Gi)
  • After prebuilds are finished, the VolumeSnapshot size is 50Gi
  • Change the user workspace class preference is standard workspace class (30Gi)
  • Open the workspace from prebuilds, the workspace can't start because the disk size dos not be increased

Workspace affected

No response

Expected behavior

@atduarte @Furisto @jenting my understanding is, that in this scenario, we want to auto upgrade the workspace class to large, so that the regular workspace being started from a large prebuild is also large. Otherwise, it will not be able to start, because the restore will fail as @jenting described.

Example repository

No response

Anything else?

#7901

@jenting jenting added the type: bug Something isn't working label Aug 30, 2022
@jenting jenting added the team: workspace Issue belongs to the Workspace team label Aug 30, 2022
@jenting jenting changed the title [PVC] Can open from prebuilds if prebuilds with large disk but user prefers standard disk [PVC] Can open from prebuilds if prebuilds with large workspace class but user prefers standard workspace class Aug 30, 2022
@jenting
Copy link
Contributor Author

jenting commented Aug 30, 2022

Related to #11912

@jenting
Copy link
Contributor Author

jenting commented Aug 30, 2022

my understanding is, that in this scenario, we want to auto upgrade the workspace class to large, so that the regular workspace being started from a large prebuild is also large.

@kylos101 correct

@atduarte
Copy link
Contributor

my understanding is, that in this scenario, we want to auto upgrade the workspace class to large, so that the regular workspace being started from a large prebuild is also large.

That's correct, given the current technical impossibility of doing it differently.

@sagor999
Copy link
Contributor

@jenting would not this be fixed by #11912 ?

@jenting
Copy link
Contributor Author

jenting commented Aug 30, 2022

@jenting would not this be fixed by #11912 ?

From my testing, nope.

@jenting jenting changed the title [PVC] Can open from prebuilds if prebuilds with large workspace class but user prefers standard workspace class [PVC] Can't open from prebuilds if prebuilds with large workspace class but user prefers standard workspace class Sep 6, 2022
@jenting jenting moved this to In Progress in 🌌 Workspace Team Sep 8, 2022
@jenting
Copy link
Contributor Author

jenting commented Sep 8, 2022

I verified this issue with PR #12734, and it works well.

Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Sep 8, 2022
@jenting jenting moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Sep 9, 2022
@Furisto Furisto moved this from In Validation to Done in 🌌 Workspace Team Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants