-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: create config command and deprecate init command #12679
Conversation
/cc @gitpod-io/platform Although we have no plans to remove the |
started the job as gitpod-build-sje-installer-config-init.1 because the annotations in the pull request description changed |
c01cd06
to
72a7b0d
Compare
started the job as gitpod-build-sje-installer-config-init.3 because the annotations in the pull request description changed |
started the job as gitpod-build-sje-installer-config-init.4 because the annotations in the pull request description changed |
Hey Simon, did you notice that this change is breaking deployments to preview environments? 😬 |
@ArthurSens is that this instance? This looks to be installing ok now |
Ah yes, sorry for misreading the results :) @mads-hartmann, as simon points out, I don't think we need to change the installer plugin in ArgoCD/workspace clusters/preview right now, but should we add issues to the schedule? |
@ArthurSens phew. I've created #12847 to capture the SaaS deployment work |
@ArthurSens @mrsimonemms For SaaS deployment we only use the render command. I left a comment here |
They also don't use the init command as far as I can tell (ref)
@mrsimonemms could I persuade you to update this line to use |
@mads-hartmann ooooh, you drive a hard bargain. But, seeing as you asked so nicely 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks Simon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and code looks good to me!
Description
Create a
config init
command and deprecate theinit
command.The two commands are functionally identical, with the exception of the new command saving the file for you (the previous command just printed the output).
This is part of a major refactoring of the configuration so that it's simpler and just config generation. See #12319 for my notepad of how it'll look eventually.
Related Issue(s)
Fixes #12678
Fixes #12847
How to test
Run
go run . config init
and checkgitpod.config.yaml
Release Notes
Documentation
Werft options: