Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: create config command and deprecate init command #12679

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Sep 6, 2022

Description

Create a config init command and deprecate the init command.

The two commands are functionally identical, with the exception of the new command saving the file for you (the previous command just printed the output).

This is part of a major refactoring of the configuration so that it's simpler and just config generation. See #12319 for my notepad of how it'll look eventually.

Related Issue(s)

Fixes #12678
Fixes #12847

How to test

Run go run . config init and check gitpod.config.yaml

Release Notes

[installer]: create config command and deprecate init command

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms
Copy link
Contributor Author

/cc @gitpod-io/platform Although we have no plans to remove the init command, we should migrate any scripts from installer init to installer config init

@mrsimonemms mrsimonemms requested a review from a team September 6, 2022 09:46
@mrsimonemms mrsimonemms marked this pull request as ready for review September 6, 2022 09:46
@mrsimonemms mrsimonemms requested a review from a team September 6, 2022 09:46
@github-actions github-actions bot added team: devx team: delivery Issue belongs to the self-hosted team labels Sep 6, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sje-installer-config-init.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mrsimonemms mrsimonemms force-pushed the sje/installer-config-init branch from c01cd06 to 72a7b0d Compare September 9, 2022 14:12
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sje-installer-config-init.3 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sje-installer-config-init.4 because the annotations in the pull request description changed
(with .werft/ from main)

@ArthurSens
Copy link
Contributor

ArthurSens commented Sep 9, 2022

Hey Simon, did you notice that this change is breaking deployments to preview environments? 😬

@mrsimonemms
Copy link
Contributor Author

@ArthurSens is that this instance? This looks to be installing ok now

@ArthurSens
Copy link
Contributor

Ah yes, sorry for misreading the results :)

@mads-hartmann, as simon points out, I don't think we need to change the installer plugin in ArgoCD/workspace clusters/preview right now, but should we add issues to the schedule?

@mrsimonemms
Copy link
Contributor Author

@ArthurSens phew.

I've created #12847 to capture the SaaS deployment work

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 10, 2022

@ArthurSens @mrsimonemms For SaaS deployment we only use the render command. I left a comment here ☺️

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 10, 2022

workspace clusters

They also don't use the init command as far as I can tell (ref)

previews

@mrsimonemms could I persuade you to update this line to use config init as part of this PR? Then we should be all good and not use the deprecated command anywhere that I can remember right now at least ☺️

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Sep 10, 2022

@mads-hartmann ooooh, you drive a hard bargain. But, seeing as you asked so nicely 😃

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Simon!

Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code looks good to me! :shipit:

@roboquat roboquat merged commit bb369ab into main Sep 12, 2022
@roboquat roboquat deleted the sje/installer-config-init branch September 12, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L team: delivery Issue belongs to the self-hosted team team: devx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the SaaS deployment process to use the refactored config commands Create a config command
5 participants