[installer]: build the config #12687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
18 times, most recently
from
02959f7 to
aa7dba0
Compare
|
/werft run 👍 started the job as gitpod-build-sje-installer-config-build.21 |
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
aa7dba0 to
702f20c
Compare
|
/hold until all the permutations are confirmed complete |
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
702f20c to
44b36b5
Compare
|
/werft run publish-to-kots 👍 started the job as gitpod-build-sje-installer-config-build.24 |
github-actions
bot
added
the
team: delivery
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
44b36b5 to
f93e57a
Compare
|
started the job as gitpod-build-sje-installer-config-build.27 because the annotations in the pull request description changed |
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
f93e57a to
d1063d3
Compare
13 tasks
|
/werft run with-sh-preview 👍 started the job as gitpod-build-sje-installer-config-build.28 |
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
d1063d3 to
a3941fa
Compare
|
/unhold |
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
a3941fa to
3e88f56
Compare
Pothulapati
reviewed
Sep 20, 2022
Pothulapati
suggested changes
Sep 20, 2022
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
3e88f56 to
024b467
Compare
|
@Pothulapati added the comment we talked about. Thanks for your help 🧡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a
config build-from-envvarscommand that replaces all of the bash script config generation with a Golang file. This ties the envvars to the config version. This means that the envvars are now part of our public contract.This is part of a major refactoring of the configuration so that it's simpler and just config generation.
See #12319 for my notepad of how it'll look eventually.Related Issue(s)
Fixes #12199
How to test
As per #12986
Release Notes
Documentation
Werft options: