-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: config detects shiftfs and containerd values #12683
Conversation
5d85fa2
to
734639b
Compare
734639b
to
2207bee
Compare
/werft run with-sh-preview 👍 started the job as gitpod-build-sje-installer-config-detect.5 |
/werft run with-sh-preview cluster=gke 👍 started the job as gitpod-build-sje-installer-config-detect.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can't wait to see it used in KOTS installer config!
Ran self-hosted tests on k3s and GKE to make sure normal installation isn't affected.
Thanks @nandajavarma, much appreciated |
Description
This creates two new commands -
config cluster shiftfs
andconfig files containerd
- designed to autodetect whether ShiftFS is supported and the location of the containerd files.The ShiftFS command reuses the init container in
ws-daemon
.The command
config cluster
andconfig files
have been designed so that future commands can be written. Theconfig cluster
is designed for commands that deploy a Kubernetes resource to get the answer and theconfig files
is designed for commands that are run against the file system, either on the cluster or against a mounted volume in a pod.This is part of a major refactoring of the configuration so that it's simpler and just config generation. See #12319 for my notepad of how it'll look eventually.
Related Issue(s)
Fixes #12198
How to test
Run the commands. This should be run on an instance that supports ShiftFS (ie, not Azure/k3s) and one that does not. The
config files containerd
command will need to be run on a cluster - you may test with the following script on your test cluster (this should run without error and set thecontainerdRuntimeDir
andcontainerdSocket
at the bottom:Release Notes
Documentation
Werft options: