Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable PVC support #12014

Merged
merged 2 commits into from
Aug 22, 2022
Merged

re-enable PVC support #12014

merged 2 commits into from
Aug 22, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Aug 9, 2022 •
edited
Loading

Description

This PR contains two fixes:

  1. Re-enables PVC support in ws-manager
  2. Fixes PVC not working when restoring from prebuild.

Related Issue(s)

Fixes #

Needs following merged and deployed into webapp prod prior to merging:
✔️ #12105
✔️ #12165
✔️ #12180

How to test

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@sagor999 sagor999 force-pushed the pavel/pvc-enable branch 2 times, most recently from 7b2b9e9 to 77aa1bf Compare August 11, 2022 18:33
@roboquat roboquat added size/S and removed size/XS labels Aug 11, 2022
@sagor999 sagor999 changed the title [ws-manager] remove hack that was disabling PVC feature re-enable PVC support Aug 12, 2022
@kylos101
Copy link
Contributor

@sagor999 should you undo this too? cc: @aledbf

@sagor999
Copy link
Contributor Author

@kylos101 that's already done. check commits in this PR.

@sagor999 sagor999 mentioned this pull request Aug 16, 2022
Merged
1 task
@sagor999 sagor999 force-pushed the pavel/pvc-enable branch 2 times, most recently from c419179 to 2487f02 Compare August 19, 2022 22:25
@roboquat roboquat removed the size/L label Aug 19, 2022
@sagor999 sagor999 marked this pull request as ready for review August 19, 2022 22:25
@sagor999 sagor999 requested a review from a team August 19, 2022 22:25
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 19, 2022
@roboquat roboquat merged commit b7cb201 into main Aug 22, 2022
@roboquat roboquat deleted the pavel/pvc-enable branch August 22, 2022 00:07
@kylos101
Copy link
Contributor

@sagor999 added to our project and set to awaiting deployment

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sagor999 @kylos101 @utam0k @roboquat