[server] ensure that user that has PVC enabled will not force prebuilds into PVC use #12165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-pavel-11769.1 because the annotations in the pull request description changed |
sagor999
force-pushed
the
pavel/11769
branch
2 times, most recently
from
6c1da16 to
cc19ac7
Compare
roboquat
added
size/S
release-note-none
and removed
size/M
do-not-merge/release-note-label-needed
labels
geropl
reviewed
Aug 17, 2022
geropl
reviewed
Aug 17, 2022
| // If PVC is disabled for prebuilds, we need to remove the PVC feature flag. | ||
| // This is necessary to ensure if user has PVC enabled on their account, that they | ||
| // will not hijack prebuild with PVC and make everyone who use this prebuild to auto enroll into PVC feature. | ||
| featureFlags = featureFlags.filter((f) => f !== "persistent_volume_claim"); |
…ds to use them on projects that don't have PVC turned on
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ensure that user that has PVC enabled will not force prebuilds to use them on projects that don't have PVC turned on
Related Issue(s)
Fixes #11769
How to test
Release Notes
Documentation
Werft options: