[server] fix using snapshotBucketId when it is undefined or empty

[sagor999]

Description

Related Issue(s)

Fixes #11823

How to test

Release Notes

none

Documentation

Werft options:

• /werft with-preview

[sagor999]

@kylos101 FYI 👀

[sagor999]

@geropl could you confirm is passing undefined into
const volumeSnapshots = await this.workspaceDb.trace(traceCtx).findVolumeSnapshotById(volumeSnapshotId);
which calls:

gitpod/components/gitpod-db/src/typeorm/workspace-db-impl.ts

Lines 741 to 744 in 14b3920

	public async findVolumeSnapshotById(volumeSnapshotId: string): Promise<VolumeSnapshot | undefined> {
	const volumeSnapshots = await this.getVolumeSnapshotRepo();
	return volumeSnapshots.findOne(volumeSnapshotId);
	}

findOne(volumeSnapshotId)
I suspect it does not handle undefined variable properly here. But maybe I am wrong.
Does it? I have a feeling it returns random record if undefined is passed into it.

[werft-gitpod-dev-com]

started the job as gitpod-build-pavel-fix-pvc-picking.2 because the annotations in the pull request description changed
(with .werft/ from main)

[geropl]

I suspect it does not handle undefined variable properly here. But maybe I am wrong.
Does it? I have a feeling it returns random record if undefined is passed into it.

You're right in that it is not handled properly. undefined should map to an "empty" value, which that is depends on the column definition/mapping code. So it could be that it pulls any record that is empty (haven't checked nor tested).

[geropl]

Code LGTM! 👍