Add S3 bucket name to kots config #10188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
|
/hold This PR depends on the following PRs for proper working: |
sagor999
suggested changes
May 23, 2022
nandajavarma
force-pushed
the
nvn/fix-10100
branch
from
a6ec95b to
3f7e3e1
Compare
sagor999
approved these changes
May 24, 2022
nandajavarma
force-pushed
the
nvn/fix-10100
branch
from
3f7e3e1 to
50bd007
Compare
Co-authored-by: Pavel Tumik <[email protected]>
nandajavarma
force-pushed
the
nvn/fix-10100
branch
from
50bd007 to
b27fefc
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #10073 , this PR adds the bucket name option to the KOTS config. This PR depends on the following PRs for proper working:
The resulting UI would have the following content:
Related Issue(s)
Fixes #10100
How to test
Setting up replicated with the changes from this PR and the above mentioned PRs will give the option to provide bucket name.
Release Notes
Documentation