Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots] Fix s3 secret typo in gitpod installer job #10083

Merged
merged 1 commit into from
May 24, 2022

Conversation

shaoye
Copy link
Contributor

@shaoye shaoye commented May 17, 2022

Description

kind: secret is miswritten in secret: secret, causing installer render to fail

Related Issue(s)

Fixes #9911

How to test

Release Notes

None

Documentation

`kind: secret` is miswritten in `secret: secret`, causing installer render to fail
@shaoye shaoye requested a review from a team May 17, 2022 22:27
@nandajavarma nandajavarma added the team: delivery Issue belongs to the self-hosted team label May 18, 2022
@nandajavarma
Copy link
Contributor

Thanks a lot for this contribution @shaoye and great catch! I will test this ASAP. In the meantime, do you mind adding a NONE to the release notes, which is what we use for PRs with no user facing changes. Here is an example PR with NONE release note.

@corneliusludmann
Copy link
Contributor

corneliusludmann commented May 19, 2022

/werft run no-preview

👍 started the job as gitpod-build-patch-1-fork.8
(with .werft/ from main)

@nandajavarma nandajavarma added the do-not-merge/cla-pending CLA has not been signed label May 20, 2022
@nandajavarma
Copy link
Contributor

This change has been tested and works great! Thanks again for making this contribution @shaoye ! Before we can merge this PR, we need you to sign a Contributor License Agreement and this is the reason for the delay in merging.

cc @meysholdt to organize the CLA signing steps. We are hoping to release this change with the May release. Would be great if we can escalate this!

@meysholdt
Copy link
Member

hi @shaoye, I've emailed our CLA your way, and you can conveniently sign it via DocuSign. If there are questions, feel free to reach me via [email protected].

@meysholdt
Copy link
Member

hi @shaoye , thank you for signing the CLA!

@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels May 24, 2022
Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@roboquat roboquat merged commit 9cc640e into gitpod-io:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOTS: S3 external object storage is not working
6 participants