-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kots] Fix s3 secret typo in gitpod installer job #10083
Conversation
`kind: secret` is miswritten in `secret: secret`, causing installer render to fail
Thanks a lot for this contribution @shaoye and great catch! I will test this ASAP. In the meantime, do you mind adding a |
/werft run no-preview 👍 started the job as gitpod-build-patch-1-fork.8 |
This change has been tested and works great! Thanks again for making this contribution @shaoye ! Before we can merge this PR, we need you to sign a Contributor License Agreement and this is the reason for the delay in merging. cc @meysholdt to organize the CLA signing steps. We are hoping to release this change with the May release. Would be great if we can escalate this! |
hi @shaoye, I've emailed our CLA your way, and you can conveniently sign it via DocuSign. If there are questions, feel free to reach me via |
hi @shaoye , thank you for signing the CLA! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
kind: secret
is miswritten insecret: secret
, causing installer render to failRelated Issue(s)
Fixes #9911
How to test
Release Notes
Documentation