[kots]: add storage to preflight checks #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/kots-storage-check
branch
4 times, most recently
from
a11fb2e to
1fccdca
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-storage-check.6 |
mrsimonemms
changed the title
github-actions
bot
added
the
team: delivery
There was a problem hiding this comment.
Great!
Putting this on hold for now until we handled my comments in #9759.
mrsimonemms
force-pushed
the
sje/kots-config-check
branch
from
9271a07 to
5f69faf
Compare
mrsimonemms
force-pushed
the
sje/kots-storage-check
branch
from
1fccdca to
f2aec10
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-storage-check.8 |
This checks the connection is correct, based upon the configuration given.
mrsimonemms
force-pushed
the
sje/kots-storage-check
branch
from
f2aec10 to
4db0500
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-storage-check.10 |
nandajavarma
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a storage check to the KOTS preflight checks. This validates that the given configuration is able to create a bucket, upload a file, download a file and then delete the bucket. The bucket names include two randomly generated strings to avoid global name collisions. This checks against Azure, GCP and S3.
In-cluster connections always return as valid
Arguably, it may look a little strange how I've done the test. As the test is for the connection to be valid and we use the commands, I took the view that testing that it's able to fulfil the required requests was a good idea as there's no "are these credentials valid?" command. I'm open to a discussion on a better way if you can think of one
NB Azure doesn't test the region because this is defined on the storage account and the access key/secret are generated within the storage account.
Related Issue(s)
Fixes #9933
How to test
Install with KOTS - the version to use is
sje-kots-storage-check.10insje/kots-storage-checkchannelRelease Notes
Documentation