-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Migrate to Installer #9097
Labels
Comments
This was referenced Apr 11, 2022
This was referenced Apr 14, 2022
This was referenced Apr 22, 2022
This was referenced Apr 29, 2022
This was referenced May 5, 2022
Finally closing this after all boxes are ticked. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
WebApp is the last team that relies on the helm chart for deployments, we should get rid of it.
General approach
Go through components one by one and decide for each config to either:
Tasks
open-vsx
server
maximumBackupCount
andblobQuota
configuration surface to the installer #9227logLevel
from config, and take it fromLOG_LEVEL
env vardefaultBaseImageRegistryWhitelist
configurable (or is this an imageBuilder concern?)definitelyGpDisabled
configurabledisableDynamicAuthProviderLogin
configurableenableLocalApp
configurablerunDbDeleter
: = !dbSync.enabledbuiltinAuthProvidersConfigured
: [server] Remove superfluous config field builtinAuthProvidersConfigured #9612add chargebee config to outer wrapper chart (cmp. old chart)already done by terraformGITPOD_ANALYTICS_WRITER
andGITPOD_ANALYTICS_SEGMENT_KEY
GITPOD_LICENSE_TYPE
in wrapper chart as expectedws-manager-bridge
add optiondone based on "installation method"skipSelf
and use it [here](https://github.com/gitpod-io/gitpod/blob/21263bd4e7acdffd1fb81c0056cc9f935159679c/install/installer/pkg/components/ws-manager-bridge/objects.go#L21)
experimental.webapp.wsManagerBridge.skipSelf
(default: false, set totrue
for SaaS)db-sync
(wrapper chart)disableMigration
(default: false): disable jobsdbinit-session
andmigrations
&db-init
configMapmessagebus
(well-tested in preview envs)payment-endpoint
(wrapper chart)PodConfig
section under a newCommon
field, to make it clearer that these values are cross-cutting and applicable to all teams.Affinity
method incommon
package toNodeAffinity
([installer] Renamecommon.Affinity
toNodeAffinity
#9400)common
everywhere.kedge
#9487dev/installer-diff
program (only needed for figuring out the diff of the installer vs helm chart).find a way to configurenot required, deprecated anywayrepositoryPasslist
Collaboration
For collaboration and questions on the remaining tasks: Notion sync doc.
Context
Historically we all deployed with the helm chart but decided to go with the installer instead.
Value
The value lies in alignment and getting rid of technical debt.
Acceptance Criteria
We can deploy using the installer in all deployment modes, and delete to helm chart.
Measurement
Does not apply
Growth Area
No response
Persona(s)
No response
Hypothesis
No response
In scope
No response
Out of scope
No response
Complexities
No response
Press release
No response
The text was updated successfully, but these errors were encountered: