[installer] Separate webapp tracing config from workspace tracing config #9900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the tracing related environment variables
JAEGER_SAMPLER_TYPE
andJAEGER_SAMPLER_PARAM
are configured underexperimental.workspace.tracing
and are applied to these components:This PR makes the
server
component take it's tracing config from a newexperimental.webapp.tracing
config, as it should not (necessarily) use the same config as the the workspace components.See this comment.
Related Issue(s)
Part of #9097
How to test
Create an installer config file containing this
experimental
section:Get a
versions.yaml
for use with the installer:Then invoke the installer as:
The
server
and workspace components will use the correct environment variables from the correct section of the config.Release Notes
Documentation
None