-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer] Allow more parts of the server config to vary #9630
Conversation
This was previously hard-coded to false in the server configmap.
This was previously hard-coded to true in the server configmap.
This was previously hard-coded to empty in the server configmap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because the code is minimal and LGTM
/hold
bonus points for adding tests, though! 🧡
Added tests for the configmap configuration done in this PR and previous ones. |
/unhold Thank you @andrew-farries ! 🙏 To fix the build issue please run |
Extract named structs for fields that were nested under `ServerConfig` so that they can be instantiated in tests.
79f54c7
to
7184057
Compare
Description
One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.
This PR makes a few parts of the server config configurable that were previously hard-coded by the installer:
disableDynamicAuthProviderLogin
enableLocalApp
defaultBaseImageRegistryWhitelist
Related Issue(s)
Part of #9097
How to test
Create an installer config file containing this
experimental
section:Get a
versions.yaml
for use with the installer:Then invoke the installer as:
The rendered output will have the values from the config for the relevant fields in the
server
ConfigMap (under theconfig.json
key).Release Notes
Documentation
None.