Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Allow the use of a static password for the message bus #9831

Merged
merged 2 commits into from
May 6, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.

This PR adds an experimental.common.staticMessagebusPassword field to set a message bus password, rather than having the installer render a fresh password on every invocation. cf this comment from @mrsimonemms.

Related Issue(s)

Part of #9097

How to test

Create an installer config file containing this experimental section:

experimental:
  common:
    staticMessagebusPassword: "some-password"

Get a versions.yaml for use with the installer:

docker run -it --rm "eu.gcr.io/gitpod-core-dev/build/versions:${version}" cat versions.yaml > versions.yaml

Then invoke the installer as:

go run . render --debug-version-file versions.yaml --config /path/to/config --use-experimental-config

The message bus password will be the value set in the config. If the experimental config section is omitted, or the staticMessagebusPassword is set to an empty string, a password will be generated.

Release Notes

Add `staticMessagebusPassword` config flag to use a fixed message bus password in the installer

Documentation

None.

Andrew Farries added 2 commits May 6, 2022 14:26
Add `experimental.common.staticMessagebusPassword` to set a static
password for the rabbit mq bus, rather than regenerating a new one on
every render.
@andrew-farries andrew-farries requested a review from a team May 6, 2022 14:30
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label May 6, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the tests! 🧡

@roboquat roboquat merged commit deba0f9 into main May 6, 2022
@roboquat roboquat deleted the af/use-static-message-bus-pw branch May 6, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants