Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for latest mini_mime update #5289

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

lildude
Copy link
Member

@lildude lildude commented Mar 26, 2021

Description

I noticed merging #5287 today resulted in two unrelated test failures that didn't occur before yesterday:

  1) Failure:
TestBlob#test_mime_type [/home/runner/work/linguist/linguist/test/test_blob.rb:17]:
Expected: "application/postscript"
  Actual: "application/pdf"

  2) Failure:
TestFileBlob#test_mime_type [/home/runner/work/linguist/linguist/test/test_file_blob.rb:31]:
Expected: "application/postscript"
  Actual: "application/pdf"

MiniMime released a new version yesterday which has pulled in the latest updates from https://github.com/mime-types/mime-types-data which has in turn pulled in @Alhadis's fix to correctly classify .ai files as PDFs in mime-types/mime-types-data#22

This PR updates our tests to reflect these changes.

[ Checklist removed as it doesn't apply ]

MiniMime released a new version yesterday which has pulled in the latest updates from https://github.com/mime-types/mime-types-data which has in turn pulled in @Alhadis's fix to correctly classify .ai files as PDFs in mime-types/mime-types-data#22
@lildude lildude requested a review from a team as a code owner March 26, 2021 16:24
@Alhadis
Copy link
Collaborator

Alhadis commented Mar 26, 2021

I was wondering about this quite recently…

@lildude lildude merged commit d23d40f into master Mar 26, 2021
@lildude lildude deleted the lildude/update-mime-type-tests branch March 26, 2021 17:46
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants