Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch C# grammar to official dotnet repo #5287

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 24, 2021

Description

dotnet/tmLanguage is now switched from oniguruma to PCRE grammar (dotnet/csharp-tmLanguage#187), so we can cut the middleman which was potentially just replacing '-' with '' for oniguruma->PCRE conversion.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@am11 am11 requested a review from a team as a code owner March 24, 2021 14:37
@am11
Copy link
Contributor Author

am11 commented Mar 24, 2021

cc @JoeRobich

@lildude lildude merged commit 35b5667 into github-linguist:master Mar 26, 2021
@am11 am11 deleted the feature/lang/csharp branch March 26, 2021 15:30
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants