Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe Illustrator files should use application/pdf #22

Closed
Alhadis opened this issue Jul 11, 2019 · 2 comments · Fixed by #23
Closed

Adobe Illustrator files should use application/pdf #22

Alhadis opened this issue Jul 11, 2019 · 2 comments · Fixed by #23

Comments

@Alhadis
Copy link
Contributor

Alhadis commented Jul 11, 2019

This gem lists .ai files as application/postscript, but Adobe Illustrator hasn't used EPS as its native format since 2000 or so. Version 9 and onwards save artwork as ordinary PDFs with editor-specific metadata included.

See github-linguist/linguist#4572 for a related discussion.

/cc @lildude

@halostatue
Copy link
Member

I have not problem with this change, but I do not see having the time to make the change for a few weeks (even though it’s small). I can probably get a PR merged and released by next weekend if you submit a PR for the change (all you need to change are the .yml files; the tooling takes care of the rest).

@Alhadis
Copy link
Contributor Author

Alhadis commented Jul 11, 2019

Alright, done. Please let me know if there's anything I've missed. 👍

halostatue pushed a commit that referenced this issue Sep 5, 2019
developer88 added a commit to developer88/mime-types-data that referenced this issue Sep 13, 2019
After mime-types#23 (mime-types#22) now the `.preferred_extension` for `application/pdf` is `ai` which is not fully correct.
halostatue pushed a commit that referenced this issue Oct 9, 2019
After #23 (#22) now the `.preferred_extension` for `application/pdf` is `ai` which is not fully correct.
lildude added a commit to github-linguist/linguist that referenced this issue Mar 26, 2021
MiniMime released a new version yesterday which has pulled in the latest updates from https://github.com/mime-types/mime-types-data which has in turn pulled in @Alhadis's fix to correctly classify .ai files as PDFs in mime-types/mime-types-data#22
lildude added a commit to github-linguist/linguist that referenced this issue Mar 26, 2021
MiniMime released a new version yesterday which has pulled in the latest updates from https://github.com/mime-types/mime-types-data which has in turn pulled in @Alhadis's fix to correctly classify .ai files as PDFs in mime-types/mime-types-data#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants