merge beta-2 release #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so other plugins can use it too.
We can check for browser compatibility on lint time now.
Check `form-control-focus` mixin, variable name is `$input-focus-border-color`
Remove accidental `alt` addition from Bootstrap stack image.
… with !default flag
I feel like `auto` is missing from the values here and that it should be there. Although it is mentioned below, only a single use case, whereas in other sections it appears with the option to set the left margin of an element to auto, for example.
Since flex-order was renamed to just order, change the subtitle.
Solution mentioned by Chris Baswell at https://stackoverflow.com/a/45969088
We need to pass different options and this seems cleaner at this point. In order for docs.min.js to keeps all comments, we don't pass `compress`.
Overriding the focus outline for links within the dropdown menu causes accessibility issues for keyboard-only users. This removes the override, reenabling the browser's default focus outline.
* Update the form focus mixin to use a manual `$enable-shadows` check so we can always ensure a focus state for accessibility and consistency * - Add new `$input-btn-focus-width` and `$input-btn-focus-color` variables. - Replace separate `$btn-focus-box-shadow` and `$input-focus-box-shadow` variables with unified `$input-btn-focus-box-shadow` to match our combined variables approach elsewhere. * Put new focus width var to use in buttons mixins * use new button input-box shadow var * Add a new mixin for quickly adding linear gradient to components when $enable-gradients is set to true * use correct var * fix focus shadows in button mixins * Add opt-in gradients to alerts, buttons, carousel, custom radios and checkboxes, custom file input, and dropdown items * Generate .bg-gradient- utilities * add headings to colors page and document bg-gradient utils * update the button color for active status, check with yiq as it's done for basic state and hover state
Rationale: the page is not available locally, only on gh-pages, thus leading to a 404 locally.
As the diff shows, this was for a Firefox Android issue that's since been fixed. Closes #23817.
…tion to the minimum necessary (#24315) These were using `z-index: 2` to "Place active items above their siblings for proper border styling". However, using `z-index: 1` is sufficient for accomplishing that goal. In input-group, there were also three `z-index: 3` rules for the hover/focus/active states. I reduced these to `z-index: 2` since they just needed to be "one more than normal" (i.e. one more than what is now `z-index: 1` after my changes). These changes can be verified by viewing the documentation pages for Button group, Input group, List group, and Pagination before and after this commit and observing that the active elements are still "above" their siblings, so their borders look correct.
If the content of the page does not extend the full viewport height, the sidebars were shortened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.