Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for 3.3 404s #24445

Closed
sunnyrjuneja opened this issue Oct 19, 2017 · 3 comments
Closed

Docs for 3.3 404s #24445

sunnyrjuneja opened this issue Oct 19, 2017 · 3 comments

Comments

@sunnyrjuneja
Copy link

When you visit http://getbootstrap.com/ and then click the drop down for version and select 3.3.7, it links to: https://getbootstrap.com/3.3/ which 404s.

@sunnyrjuneja
Copy link
Author

It appears the correct url should be: https://getbootstrap.com/docs/3.3/. I will submit a PR.

@sunnyrjuneja
Copy link
Author

The problem appears to be in

<div class="dropdown-menu dropdown-menu-right" aria-labelledby="bd-versions">
<a class="dropdown-item active" href="{{ site.baseurl }}/docs/{{ site.docs_version }}/">Latest (4.x)</a>
<a class="dropdown-item" href="https://v4-alpha.getbootstrap.com/">v4 Alpha 6</a>
<a class="dropdown-item" href="https://getbootstrap.com/3.3/">v3.3.7</a>
<a class="dropdown-item" href="https://getbootstrap.com/2.3.2/">v2.3.2</a>
</div>

The link to 2.3.2 docs works. It appears the path has changed only for v3. Please advice if the path should be reverted or the link should be prefixed with /docs/. Feel free to handle this yourself if you prefer to (although I'm still happy to submit a PR).

@sunnyrjuneja
Copy link
Author

thanks @mdo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants