Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes margin for pre on _code.scss since it's already set on _reboot.scss #24366

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Removes margin for pre on _code.scss since it's already set on _reboot.scss #24366

merged 2 commits into from
Oct 20, 2017

Conversation

andresgalante
Copy link
Collaborator

Reboot defines margins for pre https://github.com/twbs/bootstrap/blob/v4-dev/scss/_reboot.scss#L247-L249

This PR removes the pre margin definition on _code.scss

mdo
mdo approved these changes Oct 14, 2017
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, slating for Beta 3 so we can slim down remaining Beta 2 todos.

@mdo mdo mentioned this pull request Oct 20, 2017
Closed
@XhmikosR XhmikosR merged commit a89187f into v4-dev Oct 20, 2017
@XhmikosR XhmikosR deleted the v4-dev-andres-removes-duplicated-margin-on-pre branch October 20, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresgalante @mdo @XhmikosR