Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KSM alerts from Atlas to Turtles #889

Closed
wants to merge 16 commits into from
Closed

Move KSM alerts from Atlas to Turtles #889

wants to merge 16 commits into from

Conversation

TheoBrigitte
Copy link
Member

Towards: https://github.com/giantswarm/giantswarm/issues/27172

Moving all VerticalPodAutoscaler and KubeStateMetrics related alerts from Atlas to Turtles.

/!\ Does Turtles alerting works ?

@TheoBrigitte TheoBrigitte requested a review from a team as a code owner August 21, 2023 16:39
@TheoBrigitte TheoBrigitte self-assigned this Aug 21, 2023
@TheoBrigitte TheoBrigitte requested a review from a team August 21, 2023 16:39
@TheoBrigitte TheoBrigitte requested a review from a team August 29, 2023 14:43
@TheoBrigitte TheoBrigitte requested review from a team and removed request for a team August 29, 2023 14:44
@TheoBrigitte
Copy link
Member Author

TheoBrigitte commented Aug 29, 2023 •
edited
Loading

Updated alerts to use phoenix routing instead of turtles

hervenicol
hervenicol approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheoBrigitte
Copy link
Member Author

@giantswarm/team-phoenix @giantswarm/team-turtles can I please get a review here ?

FYI KubeStateMetricsDown alert is currently still noisy, we already provided some fixes

and more are being worked on

fiunchinho
fiunchinho requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd hold this PR until KSM issues are fixed. It's currently paging a lot and atlas has the knowledge about the tool and the work that's currently being done.

@TheoBrigitte
Copy link
Member Author

I'd hold this PR until KSM issues are fixed. It's currently paging a lot and atlas has the knowledge about the tool and the work that's currently being done.

Yes we agreed to keep this open for another week, so we can then check if the situation improved with the KubeStateMetricsDown alert. (fixes are in place https://github.com/giantswarm/giantswarm/issues/27937#issuecomment-1713944206)

@TheoBrigitte TheoBrigitte mentioned this pull request Oct 3, 2023
Merged
@Gacko Gacko requested review from a team and fiunchinho December 7, 2023 18:25
@Gacko
Copy link
Member

Gacko commented Dec 10, 2023

What's the current status on this?

@TheoBrigitte TheoBrigitte changed the title Move VPA and KSM alerts from Atlas to Turtles Move KSM alerts from Atlas to Turtles Dec 12, 2023
Gacko
Gacko requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current state of the PR is outdated and needs a rebase.

@TheoBrigitte
Copy link
Member Author

TheoBrigitte commented Apr 16, 2024 •
edited
Loading

Is this still needed ? @giantswarm/team-atlas @giantswarm/team-phoenix
I updated this PR in case we need to merge it.

@QuentinBisson QuentinBisson deleted the atlas-turtle-handover branch November 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko requested changes

@hervenicol hervenicol hervenicol approved these changes

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

@TheoBrigitte TheoBrigitte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheoBrigitte @Gacko @fiunchinho @hervenicol