Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move KSM alerts from Atlas to Turtles #889

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Change ownership from Atlas to Turtles/Phoenix for all vertical pod autoscaler and kube state metrics related alerts.
- Loki alerts only during working hours
- `PrometheusAgentFailing` does not rely on KSM metrics anymore
- Prometheus-agent inhibition rework, run on the MC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
cancel_if_kubelet_down: "true"
cancel_if_outside_working_hours: "true"
severity: page
team: atlas
team: phoenix
topic: observability
- alert: KubeConfigMapCreatedMetricMissing
annotations:
Expand All @@ -39,7 +39,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeDaemonSetCreatedMetricMissing
annotations:
Expand All @@ -52,7 +52,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeDeploymentCreatedMetricMissing
annotations:
Expand All @@ -65,7 +65,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeEndpointCreatedMetricMissing
annotations:
Expand All @@ -78,7 +78,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeNamespaceCreatedMetricMissing
annotations:
Expand All @@ -91,7 +91,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeNodeCreatedMetricMissing
annotations:
Expand All @@ -104,7 +104,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubePodCreatedMetricMissing
annotations:
Expand All @@ -117,7 +117,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeReplicaSetCreatedMetricMissing
annotations:
Expand All @@ -130,7 +130,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeSecretCreatedMetricMissing
annotations:
Expand All @@ -143,7 +143,7 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
- alert: KubeServiceCreatedMetricMissing
annotations:
Expand All @@ -156,5 +156,5 @@ spec:
cancel_if_outside_working_hours: "true"
cancel_if_kube_state_metrics_down: "true"
severity: page
team: atlas
team: phoenix
topic: kubernetes
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ spec:
cancel_if_kubelet_down: "true"
cancel_if_outside_working_hours: "false"
severity: page
team: atlas
team: phoenix
topic: observability
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ spec:
cancel_if_scrape_timeout: "true"
cancel_if_outside_working_hours: "true"
severity: page
team: atlas
team: phoenix
TheoBrigitte marked this conversation as resolved.
Show resolved Hide resolved
topic: observability
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ spec:

# -- VPA
# Amount of requests for VPA
- expr: label_replace(count(up{app=~'vertical-pod-autoscaler.*'}) by (cluster_type,cluster_id), "label_application_giantswarm_io_team", "atlas", "", "")
- expr: label_replace(count(up{app=~'vertical-pod-autoscaler.*'}) by (cluster_type,cluster_id), "label_application_giantswarm_io_team", "phoenix", "", "")
labels:
class: MEDIUM
area: platform
Expand All @@ -344,7 +344,7 @@ spec:
# and summed with 1 so the final result is 0 : no error recorded.
# If up was unsuccessful, there is an error. Up returns 0, multiplied by -1 and summed
# with 1 so the final result is 1 : 1 error is recorded .
- expr: label_replace(sum((up{app=~'vertical-pod-autoscaler.*'} * -1) + 1) by (cluster_id, cluster_type), "label_application_giantswarm_io_team", "atlas", "", "")
- expr: label_replace(sum((up{app=~'vertical-pod-autoscaler.*'} * -1) + 1) by (cluster_id, cluster_type), "label_application_giantswarm_io_team", "phoenix", "", "")
TheoBrigitte marked this conversation as resolved.
Show resolved Hide resolved
labels:
class: MEDIUM
area: platform
Expand Down
10 changes: 5 additions & 5 deletions test/tests/providers/global/up.all.rules.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ tests:
cancel_if_outside_working_hours: "false"
inhibit_kube_state_metrics_down: "true"
severity: "page"
team: "atlas"
team: "phoenix"
topic: "observability"
exp_annotations:
description: "KubeStateMetrics () is down."
Expand All @@ -80,7 +80,7 @@ tests:
cancel_if_outside_working_hours: "false"
inhibit_kube_state_metrics_down: "true"
severity: "page"
team: "atlas"
team: "phoenix"
topic: "observability"
exp_annotations:
description: "KubeStateMetrics () is down."
Expand Down Expand Up @@ -108,7 +108,7 @@ tests:
cancel_if_outside_working_hours: "false"
inhibit_kube_state_metrics_down: "true"
severity: "page"
team: "atlas"
team: "phoenix"
topic: "observability"
exp_annotations:
description: "KubeStateMetrics () is down."
Expand Down Expand Up @@ -161,7 +161,7 @@ tests:
cancel_if_outside_working_hours: "false"
inhibit_kube_state_metrics_down: "true"
severity: "page"
team: "atlas"
team: "phoenix"
topic: "observability"
exp_annotations:
description: "KubeStateMetrics () is down."
Expand All @@ -183,7 +183,7 @@ tests:
cancel_if_outside_working_hours: "false"
inhibit_kube_state_metrics_down: "true"
severity: "page"
team: "atlas"
team: "phoenix"
topic: "observability"
exp_annotations:
description: "KubeStateMetrics () is down."
Expand Down