Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handover VPA alert to turtle/phoenix #919

Merged
merged 3 commits into from
Oct 5, 2023
Merged

handover VPA alert to turtle/phoenix #919

merged 3 commits into from
Oct 5, 2023

Conversation

TheoBrigitte
Copy link
Member

Towards: giantswarm/giantswarm#27172

Move all VPA related alerts ownership to team turtle and phoenix.

@TheoBrigitte TheoBrigitte requested a review from a team as a code owner September 29, 2023 10:43
@TheoBrigitte TheoBrigitte self-assigned this Sep 29, 2023
@TheoBrigitte TheoBrigitte requested review from a team September 29, 2023 10:44
@QuentinBisson
Copy link
Contributor

I think you're missing thé webhook one

@TheoBrigitte
Copy link
Member Author

I think you're missing thé webhook one

Which one is that ?

@TheoBrigitte
Copy link
Member Author

Alright I added WorkloadClusterWebhookDurationExceedsTimeoutPhoenix by splitting it from WorkloadClusterWebhookDurationExceedsTimeoutAtlas

@QuentinBisson
Copy link
Contributor

Nice, sorry i was not on my laptop :)

@TheoBrigitte
Copy link
Member Author

I would need a review from @giantswarm/team-turtles and/or @giantswarm/team-phoenix here please.

@fiunchinho
Copy link
Member

When was this discussed? Was that recorded? I was interested in understanding the reasoning behind this. I was not aware phoenix was getting the VPA ownership.

@QuentinBisson
Copy link
Contributor

@fiunchinho turtles is but they are sharing the rotation with you

@TheoBrigitte
Copy link
Member Author

When was this discussed? Was that recorded? I was interested in understanding the reasoning behind this. I was not aware phoenix was getting the VPA ownership.

This was discussed on August 10th with @giantswarm/team-turtles, but then held along with KSM in this other PR for no reason #889
VPA ownership is now in Turtle and so should be the alerts.

@TheoBrigitte TheoBrigitte merged commit df2869a into master Oct 5, 2023
4 checks passed
@TheoBrigitte TheoBrigitte deleted the vpa-turtle branch October 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieroque marieroque marieroque approved these changes

@QuentinBisson QuentinBisson QuentinBisson approved these changes

@fiunchinho fiunchinho fiunchinho approved these changes

Assignees

@TheoBrigitte TheoBrigitte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheoBrigitte @QuentinBisson @fiunchinho @marieroque