Unique rule names for multiple CloudWatch expressions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning Troposphere for breaking change
edudobay
force-pushed
the
unique-rule-names-for-multiple-cloudwatch-expressions
branch
from
51e6a46 to
65775ea
Compare
* Create CONTRIBUTING.md Co-authored-by: Will Boyce <[email protected]>
* wait for lambda to become active during deployment * wait for lambda to become active during update * split active/updated waiters into separate functions * explicitly wait during update_lambda_function too
* run ci on pushes to master in addition to PRs * restore coveralls test coverage tracking * update README
A mixture of two cases that were handled individually uncovers an incorrect behavior: when a function has multiple event expressions AND the resulting rule name would be >= 64 characters long, all expressions get the same hash, so only the last expression is scheduled. In this commit, the index of the expression is used to build the hash, but only if the index is not zero — this is possibly not needed, but ensures current hashes are preserved.
edudobay
force-pushed
the
unique-rule-names-for-multiple-cloudwatch-expressions
branch
from
65775ea to
e8bfa29
Compare
|
Closing in favor of zappa#2 |
edudobay
deleted the
unique-rule-names-for-multiple-cloudwatch-expressions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A mixture of two cases that were handled individually uncovers an incorrect behavior: when a function has multiple event expressions AND the resulting rule name would be >= 64 characters long, all expressions get the same hash, so only the last expression is scheduled.
In this commit, the index of the expression is used to build the hash, but only if the index is not zero — this is possibly not needed, but ensures current hashes are preserved.
GitHub Issues