Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax stage name restrictions when not using apigateway #993

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

wrboyce
Copy link
Member

@wrboyce wrboyce commented Jun 24, 2021

Stage name restrictions are in place due to limitations on the naming of CloudFormation stacks which is not a concern when API Gateway is not in use.

@wrboyce wrboyce force-pushed the relax-stage-name branch 2 times, most recently from bf751de to 683fc7c Compare June 25, 2021 09:21
Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🥳 added a small comment, hopefully not too nitpicky 😅

zappa/cli.py Outdated Show resolved Hide resolved
@wrboyce wrboyce requested a review from hellno October 1, 2021 13:43
Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏽🙌🏽🙌🏽

@wrboyce wrboyce merged commit 26cc1d6 into zappa:master Oct 4, 2021
@wrboyce wrboyce deleted the relax-stage-name branch October 4, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants